The following document contains the results of FindBugs Report
FindBugs Version is 2.0.0
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in jpl.pds.parser.MetaDataHandler.main(String[]): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 129 | High |
Possible null pointer dereference of hostname in jpl.pds.parser.MetaDataHandler.queryForMetaData(XMLQuery, File, String[]) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 59 | Medium |
Double assignment of result in jpl.pds.parser.MetaDataHandler.queryForMetaData(XMLQuery, File, String[]) | STYLE | SA_LOCAL_DOUBLE_ASSIGNMENT | 99 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new jpl.pds.parser.ODLLexer(LexerSharedInputState) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 44 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
jpl.pds.parser.ODLParser._tokenNames should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 724 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
jpl.pds.parser.ReadLabelFile.read(String) might ignore java.io.IOException | BAD_PRACTICE | DE_MIGHT_IGNORE | 149 | Medium |
Found reliance on default encoding in jpl.pds.parser.ReadLabelFile.read(String): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 57 | High |
Load of known null value in jpl.pds.parser.ReadLabelFile.read(String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 92 | Medium |
jpl.pds.parser.ReadLabelFile.deleteSpace(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 165 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in jpl.pds.parser.SAXValidation.validateFile(Document, String): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 122 | High |
jpl.pds.parser.SAXValidation.validateFile(Document, String) may fail to clean up java.io.OutputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 75 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to metaNames in jpl.pds.parser.ValidateLabelHandler.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 157 | Medium |
Found reliance on default encoding in jpl.pds.parser.ValidateLabelHandler.main(String[]): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 163 | High |
Possible null pointer dereference of hostname in jpl.pds.parser.ValidateLabelHandler.validate(XMLQuery, File, String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 63 | Medium |
Double assignment of result in jpl.pds.parser.ValidateLabelHandler.validate(XMLQuery, File, String) | STYLE | SA_LOCAL_DOUBLE_ASSIGNMENT | 134 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to righttext in jpl.pds.parser.XMLDom.convertRecurse(AST) | STYLE | DLS_DEAD_LOCAL_STORE | 223 | Medium |
Dead store to nodeTypeName in jpl.pds.parser.XMLDom.subitemNode(String, AST, AST) | STYLE | DLS_DEAD_LOCAL_STORE | 365 | Medium |
jpl.pds.parser.XMLDom.convert(AST, String[], String, RunLog) may expose internal representation by storing an externally mutable object into XMLDom.names | MALICIOUS_CODE | EI_EXPOSE_REP2 | 39 | Medium |
Possible null pointer dereference of child in jpl.pds.parser.XMLDom.convertRecurse(AST) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 199 | Medium |
Unread field: jpl.pds.parser.XMLDom.runLog | PERFORMANCE | URF_UNREAD_FIELD | 40 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
exceptional return value of java.io.File.delete() ignored in jpl.pds.server.ChunkedFileHandler$Product.close() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 150 | Medium |
Should jpl.pds.server.ChunkedFileHandler$Product be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 119 | Medium |
Unread field: jpl.pds.server.ChunkedFileHandler$Product.id | PERFORMANCE | URF_UNREAD_FIELD | 120 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null passed for nonnull parameter of queryForFile(XMLQuery, File[], String) in jpl.pds.server.DirFileListHandler.main(String[]) | CORRECTNESS | NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS | 134 | Medium |
Unread field: jpl.pds.server.DirFileListHandler.tempFilename | PERFORMANCE | URF_UNREAD_FIELD | 111 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
jpl.pds.server.DirListHandler.main(String[]) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 149 | Medium |
Unread field: jpl.pds.server.DirListHandler.tempFilename | PERFORMANCE | URF_UNREAD_FIELD | 123 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of tempFile in jpl.pds.server.FileListHandler.zipSizeFiles(String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 156 | Medium |
Unread field: jpl.pds.server.FileListHandler.tempFilename | PERFORMANCE | URF_UNREAD_FIELD | 170 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
exceptional return value of java.io.File.delete() ignored in jpl.pds.server.JPEGFileHandler.queryForFile(XMLQuery, File[], String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 125 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to labelFile in jpl.pds.server.LabelQueryHandler.queryForFile(XMLQuery, File[], String) | STYLE | DLS_DEAD_LOCAL_STORE | 36 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in jpl.pds.server.RawFileHandler.main(String[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 135 | High |
Null passed for nonnull parameter of queryForFile(XMLQuery, File[], String) in jpl.pds.server.RawFileHandler.main(String[]) | CORRECTNESS | NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS | 121 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
jpl.pds.server.ZipDFileHandler.queryForFile(XMLQuery, File[], String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 131 | Medium |
jpl.pds.server.ZipDFileHandler.main(String[]) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 214 | Medium |
Unread field: jpl.pds.server.ZipDFileHandler.DESIRED; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 193 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: jpl.pds.server.ZipFileHandler.DESIRED; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 190 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
jpl.pds.server.ZipNFileHandler.main(String[]) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 217 | Medium |
Unread field: jpl.pds.server.ZipNFileHandler.DESIRED; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 196 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
jpl.pds.server.ZipTESFileHandler.queryForFile(XMLQuery, File[], String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 120 | Medium |
Unread field: jpl.pds.server.ZipTESFileHandler.DESIRED; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 179 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
jpl.pds.util.PDS2FName.getNames(File, String, int, StringBuffer, boolean) might ignore java.io.IOException | BAD_PRACTICE | DE_MIGHT_IGNORE | 239 | Medium |
Load of known null value in jpl.pds.util.PDS2FName.getNames(File, String, int, StringBuffer, boolean) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 126 | Medium |
Potentially dangerous use of non-short-circuit logic in jpl.pds.util.PDS2FName.getNames(File, String, int, StringBuffer, boolean) | STYLE | NS_DANGEROUS_NON_SHORT_CIRCUIT | 217 | High |
jpl.pds.util.PDS2FName.deleteSpace(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 250 | Medium |