FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.0

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
344500

jpl.pds.parser.MetaDataHandler

BugCategoryDetailsLinePriority
Found reliance on default encoding in jpl.pds.parser.MetaDataHandler.main(String[]): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING129High
Possible null pointer dereference of hostname in jpl.pds.parser.MetaDataHandler.queryForMetaData(XMLQuery, File, String[]) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION59Medium
Double assignment of result in jpl.pds.parser.MetaDataHandler.queryForMetaData(XMLQuery, File, String[])STYLESA_LOCAL_DOUBLE_ASSIGNMENT99Medium

jpl.pds.parser.ODLLexer

BugCategoryDetailsLinePriority
new jpl.pds.parser.ODLLexer(LexerSharedInputState) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR44Medium

jpl.pds.parser.ODLParser

BugCategoryDetailsLinePriority
jpl.pds.parser.ODLParser._tokenNames should be package protectedMALICIOUS_CODEMS_PKGPROTECT724Medium

jpl.pds.parser.ReadLabelFile

BugCategoryDetailsLinePriority
jpl.pds.parser.ReadLabelFile.read(String) might ignore java.io.IOExceptionBAD_PRACTICEDE_MIGHT_IGNORE149Medium
Found reliance on default encoding in jpl.pds.parser.ReadLabelFile.read(String): new java.io.FileReader(File)I18NDM_DEFAULT_ENCODING57High
Load of known null value in jpl.pds.parser.ReadLabelFile.read(String)STYLENP_LOAD_OF_KNOWN_NULL_VALUE92Medium
jpl.pds.parser.ReadLabelFile.deleteSpace(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION165Medium

jpl.pds.parser.SAXValidation

BugCategoryDetailsLinePriority
Found reliance on default encoding in jpl.pds.parser.SAXValidation.validateFile(Document, String): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING122High
jpl.pds.parser.SAXValidation.validateFile(Document, String) may fail to clean up java.io.OutputStream on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE75Medium

jpl.pds.parser.ValidateLabelHandler

BugCategoryDetailsLinePriority
Dead store to metaNames in jpl.pds.parser.ValidateLabelHandler.main(String[])STYLEDLS_DEAD_LOCAL_STORE157Medium
Found reliance on default encoding in jpl.pds.parser.ValidateLabelHandler.main(String[]): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING163High
Possible null pointer dereference of hostname in jpl.pds.parser.ValidateLabelHandler.validate(XMLQuery, File, String) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION63Medium
Double assignment of result in jpl.pds.parser.ValidateLabelHandler.validate(XMLQuery, File, String)STYLESA_LOCAL_DOUBLE_ASSIGNMENT134Medium

jpl.pds.parser.XMLDom

BugCategoryDetailsLinePriority
Dead store to righttext in jpl.pds.parser.XMLDom.convertRecurse(AST)STYLEDLS_DEAD_LOCAL_STORE223Medium
Dead store to nodeTypeName in jpl.pds.parser.XMLDom.subitemNode(String, AST, AST)STYLEDLS_DEAD_LOCAL_STORE365Medium
jpl.pds.parser.XMLDom.convert(AST, String[], String, RunLog) may expose internal representation by storing an externally mutable object into XMLDom.namesMALICIOUS_CODEEI_EXPOSE_REP239Medium
Possible null pointer dereference of child in jpl.pds.parser.XMLDom.convertRecurse(AST)CORRECTNESSNP_NULL_ON_SOME_PATH199Medium
Unread field: jpl.pds.parser.XMLDom.runLogPERFORMANCEURF_UNREAD_FIELD40Medium

jpl.pds.server.ChunkedFileHandler$Product

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.delete() ignored in jpl.pds.server.ChunkedFileHandler$Product.close()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE150Medium
Should jpl.pds.server.ChunkedFileHandler$Product be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC119Medium
Unread field: jpl.pds.server.ChunkedFileHandler$Product.idPERFORMANCEURF_UNREAD_FIELD120Medium

jpl.pds.server.DirFileListHandler

BugCategoryDetailsLinePriority
Null passed for nonnull parameter of queryForFile(XMLQuery, File[], String) in jpl.pds.server.DirFileListHandler.main(String[])CORRECTNESSNP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS134Medium
Unread field: jpl.pds.server.DirFileListHandler.tempFilenamePERFORMANCEURF_UNREAD_FIELD111Medium

jpl.pds.server.DirListHandler

BugCategoryDetailsLinePriority
jpl.pds.server.DirListHandler.main(String[]) might ignore java.lang.ExceptionBAD_PRACTICEDE_MIGHT_IGNORE149Medium
Unread field: jpl.pds.server.DirListHandler.tempFilenamePERFORMANCEURF_UNREAD_FIELD123Medium

jpl.pds.server.FileListHandler

BugCategoryDetailsLinePriority
Possible null pointer dereference of tempFile in jpl.pds.server.FileListHandler.zipSizeFiles(String) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION156Medium
Unread field: jpl.pds.server.FileListHandler.tempFilenamePERFORMANCEURF_UNREAD_FIELD170Medium

jpl.pds.server.JPEGFileHandler

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.delete() ignored in jpl.pds.server.JPEGFileHandler.queryForFile(XMLQuery, File[], String)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE125Medium

jpl.pds.server.LabelQueryHandler

BugCategoryDetailsLinePriority
Dead store to labelFile in jpl.pds.server.LabelQueryHandler.queryForFile(XMLQuery, File[], String)STYLEDLS_DEAD_LOCAL_STORE36Medium

jpl.pds.server.RawFileHandler

BugCategoryDetailsLinePriority
Found reliance on default encoding in jpl.pds.server.RawFileHandler.main(String[]): new String(byte[])I18NDM_DEFAULT_ENCODING135High
Null passed for nonnull parameter of queryForFile(XMLQuery, File[], String) in jpl.pds.server.RawFileHandler.main(String[])CORRECTNESSNP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS121Medium

jpl.pds.server.ZipDFileHandler

BugCategoryDetailsLinePriority
jpl.pds.server.ZipDFileHandler.queryForFile(XMLQuery, File[], String) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM131Medium
jpl.pds.server.ZipDFileHandler.main(String[]) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION214Medium
Unread field: jpl.pds.server.ZipDFileHandler.DESIRED; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC193Medium

jpl.pds.server.ZipFileHandler

BugCategoryDetailsLinePriority
Unread field: jpl.pds.server.ZipFileHandler.DESIRED; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC190Medium

jpl.pds.server.ZipNFileHandler

BugCategoryDetailsLinePriority
jpl.pds.server.ZipNFileHandler.main(String[]) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION217Medium
Unread field: jpl.pds.server.ZipNFileHandler.DESIRED; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC196Medium

jpl.pds.server.ZipTESFileHandler

BugCategoryDetailsLinePriority
jpl.pds.server.ZipTESFileHandler.queryForFile(XMLQuery, File[], String) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM120Medium
Unread field: jpl.pds.server.ZipTESFileHandler.DESIRED; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC179Medium

jpl.pds.util.PDS2FName

BugCategoryDetailsLinePriority
jpl.pds.util.PDS2FName.getNames(File, String, int, StringBuffer, boolean) might ignore java.io.IOExceptionBAD_PRACTICEDE_MIGHT_IGNORE239Medium
Load of known null value in jpl.pds.util.PDS2FName.getNames(File, String, int, StringBuffer, boolean)STYLENP_LOAD_OF_KNOWN_NULL_VALUE126Medium
Potentially dangerous use of non-short-circuit logic in jpl.pds.util.PDS2FName.getNames(File, String, int, StringBuffer, boolean)STYLENS_DANGEROUS_NON_SHORT_CIRCUIT217High
jpl.pds.util.PDS2FName.deleteSpace(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION250Medium