FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.0

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
1209500

gov.nasa.pds.tools.LabelParserException

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.LabelParserException.getArguments() may expose internal representation by returning LabelParserException.argumentsMALICIOUS_CODEEI_EXPOSE_REP294Medium

gov.nasa.pds.tools.constants.Constants

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.constants.Constants.CATALOG_NAMES is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY41High

gov.nasa.pds.tools.containers.SimpleDictionaryChange

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.containers.SimpleDictionaryChange.getArguments() may expose internal representation by returning SimpleDictionaryChange.argumentsMALICIOUS_CODEEI_EXPOSE_REP74Medium
The field gov.nasa.pds.tools.containers.SimpleDictionaryChange.sourceDictionary is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

gov.nasa.pds.tools.dict.DictionaryWriter

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.tools.dict.DictionaryWriter.writeDictionary(Dictionary, File): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING45High

gov.nasa.pds.tools.label.AttributeStatement

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.AttributeStatement defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE153High
Class gov.nasa.pds.tools.label.AttributeStatement defines hashcode(); should it be hashCode()?CORRECTNESSNM_LCASE_HASHCODE181High

gov.nasa.pds.tools.label.DateTime

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.DateTime.getDate() may expose internal representation by returning DateTime.dateMALICIOUS_CODEEI_EXPOSE_REP69Medium
new gov.nasa.pds.tools.label.DateTime(Date) may expose internal representation by storing an externally mutable object into DateTime.dateMALICIOUS_CODEEI_EXPOSE_REP265Medium
gov.nasa.pds.tools.label.DateTime inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE42Medium

gov.nasa.pds.tools.label.GroupStatement

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.GroupStatement defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE135High
Class gov.nasa.pds.tools.label.GroupStatement defines hashcode(); should it be hashCode()?CORRECTNESSNM_LCASE_HASHCODE165High

gov.nasa.pds.tools.label.Numeric

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.Numeric inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE43Medium

gov.nasa.pds.tools.label.ObjectStatement

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.ObjectStatement defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE279High
Class gov.nasa.pds.tools.label.ObjectStatement defines hashcode(); should it be hashCode()?CORRECTNESSNM_LCASE_HASHCODE356High

gov.nasa.pds.tools.label.PointerStatement

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.PointerStatement defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE151High
Class gov.nasa.pds.tools.label.PointerStatement defines hashcode(); should it be hashCode()?CORRECTNESSNM_LCASE_HASHCODE170High
Unread public/protected field: gov.nasa.pds.tools.label.PointerStatement.externalReferenceSTYLEURF_UNREAD_PUBLIC_OR_PROTECTED_FIELD76Medium

gov.nasa.pds.tools.label.SFDULabel

BugCategoryDetailsLinePriority
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[])I18NDM_DEFAULT_ENCODING41High
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[])I18NDM_DEFAULT_ENCODING51High
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[])I18NDM_DEFAULT_ENCODING53High
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[])I18NDM_DEFAULT_ENCODING55High
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[])I18NDM_DEFAULT_ENCODING57High
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[])I18NDM_DEFAULT_ENCODING59High
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[])I18NDM_DEFAULT_ENCODING61High
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[])I18NDM_DEFAULT_ENCODING63High

gov.nasa.pds.tools.label.Scalar

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.Scalar defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE91Medium
Class gov.nasa.pds.tools.label.Scalar defines hashcode(); should it be hashCode()?CORRECTNESSNM_LCASE_HASHCODE102High

gov.nasa.pds.tools.label.Sequence

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.Sequence defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE330High
Class gov.nasa.pds.tools.label.Sequence defines hashcode(); should it be hashCode()?CORRECTNESSNM_LCASE_HASHCODE350High
gov.nasa.pds.tools.label.Sequence.toString() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION289Medium
gov.nasa.pds.tools.label.Sequence.toString(boolean) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION321Medium

gov.nasa.pds.tools.label.Set

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.Set defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE212High
Class gov.nasa.pds.tools.label.Set defines hashcode(); should it be hashCode()?CORRECTNESSNM_LCASE_HASHCODE231High
gov.nasa.pds.tools.label.Set.toString() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION171Medium
gov.nasa.pds.tools.label.Set.toString(boolean) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION203Medium

gov.nasa.pds.tools.label.SpecialPointer

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.SpecialPointer.CATALOG_KEY should be both final and package protectedMALICIOUS_CODEMS_FINAL_PKGPROTECT35Medium
gov.nasa.pds.tools.label.SpecialPointer.DESCRIPTION_KEY should be both final and package protectedMALICIOUS_CODEMS_FINAL_PKGPROTECT28Medium
gov.nasa.pds.tools.label.SpecialPointer.INDEX_KEY should be both final and package protectedMALICIOUS_CODEMS_FINAL_PKGPROTECT33Medium
gov.nasa.pds.tools.label.SpecialPointer.STRUCTURE_KEY should be both final and package protectedMALICIOUS_CODEMS_FINAL_PKGPROTECT31Medium

gov.nasa.pds.tools.label.Symbol

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.Symbol inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE33Medium

gov.nasa.pds.tools.label.TextString

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.TextString inherits equals and uses Object.hashCode()BAD_PRACTICEHE_INHERITS_EQUALS_USE_HASHCODE34Medium

gov.nasa.pds.tools.label.antlr.ODLLexer

BugCategoryDetailsLinePriority
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mBAD_TOKEN() where default case is missingSTYLESF_SWITCH_NO_DEFAULT2040Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mEOL() where default case is missingSTYLESF_SWITCH_NO_DEFAULT1970Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mIDENTIFIER() where default case is missingSTYLESF_SWITCH_NO_DEFAULT757Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mINTEGER_OR_TIME() where default case is missingSTYLESF_SWITCH_NO_DEFAULT1618Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mUNITS() where default case is missingSTYLESF_SWITCH_NO_DEFAULT1019Medium

gov.nasa.pds.tools.label.antlr.ODLLexer$DFA21

BugCategoryDetailsLinePriority
Should gov.nasa.pds.tools.label.antlr.ODLLexer$DFA21 be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC2436Medium

gov.nasa.pds.tools.label.antlr.ODLLexer$DFA32

BugCategoryDetailsLinePriority
Should gov.nasa.pds.tools.label.antlr.ODLLexer$DFA32 be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC2761Medium

gov.nasa.pds.tools.label.antlr.ODLParser

BugCategoryDetailsLinePriority
Dead store to c3 in gov.nasa.pds.tools.label.antlr.ODLParser.group_statement(Label)STYLEDLS_DEAD_LOCAL_STORE1227Medium
Dead store to id2 in gov.nasa.pds.tools.label.antlr.ODLParser.group_statement(Label)STYLEDLS_DEAD_LOCAL_STORE1209Medium
Dead store to id2 in gov.nasa.pds.tools.label.antlr.ODLParser.object_statement(Label)STYLEDLS_DEAD_LOCAL_STORE773Medium
Dead store to t in gov.nasa.pds.tools.label.antlr.ODLParser.object_statement(Label)STYLEDLS_DEAD_LOCAL_STORE760Medium
gov.nasa.pds.tools.label.antlr.ODLParser.getTokenNames() may expose internal representation by returning ODLParser.tokenNamesMALICIOUS_CODEEI_EXPOSE_REP90Medium
gov.nasa.pds.tools.label.antlr.ODLParser.tokenNames should be package protectedMALICIOUS_CODEMS_PKGPROTECT39Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.assignment_statement(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT1346Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.group_statement(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT1189Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.object_statement(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT753Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.scalar_value(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT1930Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.sequence_value(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT2360Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.simple_statement(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT514Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.statement(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT409Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.symbol_value(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT2311Medium
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.value(Label) where default case is missingSTYLESF_SWITCH_NO_DEFAULT1824Medium

gov.nasa.pds.tools.label.antlr.ODLParser$DFA10

BugCategoryDetailsLinePriority
Dead store to LA10_1 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3870Medium
Dead store to LA10_10 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3735Medium
Dead store to LA10_11 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3720Medium
Dead store to LA10_4 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3786Medium
Dead store to LA10_5 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3885Medium
Dead store to LA10_6 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3769Medium
Dead store to LA10_7 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3803Medium
Dead store to LA10_8 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3820Medium
Dead store to LA10_9 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE3752Medium

gov.nasa.pds.tools.label.antlr.ODLParser$DFA16

BugCategoryDetailsLinePriority
Dead store to LA16_1 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4011Medium
Dead store to LA16_10 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4141Medium
Dead store to LA16_11 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4156Medium
Dead store to LA16_12 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4171Medium
Dead store to LA16_2 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4026Medium
Dead store to LA16_4 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4041Medium
Dead store to LA16_5 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4058Medium
Dead store to LA16_6 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4075Medium
Dead store to LA16_7 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4092Medium
Dead store to LA16_8 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4109Medium
Dead store to LA16_9 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4126Medium

gov.nasa.pds.tools.label.antlr.ODLParser$DFA31

BugCategoryDetailsLinePriority
Dead store to LA31_41 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA31.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4945Medium
Dead store to LA31_67 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA31.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE4930Medium

gov.nasa.pds.tools.label.antlr.ODLParser$DFA39

BugCategoryDetailsLinePriority
Dead store to LA39_3 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA39.specialStateTransition(int, IntStream)STYLEDLS_DEAD_LOCAL_STORE5044Medium

gov.nasa.pds.tools.label.parser.DefaultLabelParser

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.tools.label.parser.DefaultLabelParser.consumeNewline(InputStream): new String(byte[])I18NDM_DEFAULT_ENCODING318High
Found reliance on default encoding in gov.nasa.pds.tools.label.parser.DefaultLabelParser.parseLabel(BufferedInputStream, Label, boolean): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING174High
Found reliance on default encoding in gov.nasa.pds.tools.label.parser.DefaultLabelParser.parsePartial(BufferedInputStream, Label, Label): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING424High
gov.nasa.pds.tools.label.parser.DefaultLabelParser.consumeSFDUHeader(InputStream) ignores result of java.io.InputStream.read(byte[])BAD_PRACTICERR_NOT_CHECKED283Medium
Unread field: gov.nasa.pds.tools.label.parser.DefaultLabelParser.MARK_LIMIT; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC75Medium

gov.nasa.pds.tools.label.validate.CatalogNameValidator

BugCategoryDetailsLinePriority
Call to gov.nasa.pds.tools.dict.DictIdentifier.equals(String) in gov.nasa.pds.tools.label.validate.CatalogNameValidator.checkPointers(Label, List)CORRECTNESSEC_UNRELATED_TYPES93High

gov.nasa.pds.tools.label.validate.ElementValidator

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.validate.ElementValidator.validate(AttributeStatement, Label, Dictionary) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR313Medium

gov.nasa.pds.tools.util.VersionInfo

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.util.VersionInfo.<static initializer>() may fail to clean up java.io.InputStreamEXPERIMENTALOBL_UNSATISFIED_OBLIGATION18Medium