The following document contains the results of FindBugs Report
FindBugs Version is 2.0.0
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.LabelParserException.getArguments() may expose internal representation by returning LabelParserException.arguments | MALICIOUS_CODE | EI_EXPOSE_REP | 294 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.constants.Constants.CATALOG_NAMES is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 41 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.containers.SimpleDictionaryChange.getArguments() may expose internal representation by returning SimpleDictionaryChange.arguments | MALICIOUS_CODE | EI_EXPOSE_REP | 74 | Medium |
The field gov.nasa.pds.tools.containers.SimpleDictionaryChange.sourceDictionary is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in gov.nasa.pds.tools.dict.DictionaryWriter.writeDictionary(Dictionary, File): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 45 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.AttributeStatement defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 153 | High |
Class gov.nasa.pds.tools.label.AttributeStatement defines hashcode(); should it be hashCode()? | CORRECTNESS | NM_LCASE_HASHCODE | 181 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.DateTime.getDate() may expose internal representation by returning DateTime.date | MALICIOUS_CODE | EI_EXPOSE_REP | 69 | Medium |
new gov.nasa.pds.tools.label.DateTime(Date) may expose internal representation by storing an externally mutable object into DateTime.date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 65 | Medium |
gov.nasa.pds.tools.label.DateTime inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 42 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.GroupStatement defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 135 | High |
Class gov.nasa.pds.tools.label.GroupStatement defines hashcode(); should it be hashCode()? | CORRECTNESS | NM_LCASE_HASHCODE | 165 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.Numeric inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 43 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.ObjectStatement defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 279 | High |
Class gov.nasa.pds.tools.label.ObjectStatement defines hashcode(); should it be hashCode()? | CORRECTNESS | NM_LCASE_HASHCODE | 356 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.PointerStatement defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 151 | High |
Class gov.nasa.pds.tools.label.PointerStatement defines hashcode(); should it be hashCode()? | CORRECTNESS | NM_LCASE_HASHCODE | 170 | High |
Unread public/protected field: gov.nasa.pds.tools.label.PointerStatement.externalReference | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 76 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 41 | High |
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 51 | High |
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 53 | High |
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 55 | High |
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 57 | High |
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 59 | High |
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 61 | High |
Found reliance on default encoding in new gov.nasa.pds.tools.label.SFDULabel(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 63 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.Scalar defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 91 | Medium |
Class gov.nasa.pds.tools.label.Scalar defines hashcode(); should it be hashCode()? | CORRECTNESS | NM_LCASE_HASHCODE | 102 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.Sequence defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 330 | High |
Class gov.nasa.pds.tools.label.Sequence defines hashcode(); should it be hashCode()? | CORRECTNESS | NM_LCASE_HASHCODE | 350 | High |
gov.nasa.pds.tools.label.Sequence.toString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 289 | Medium |
gov.nasa.pds.tools.label.Sequence.toString(boolean) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 321 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.Set defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 212 | High |
Class gov.nasa.pds.tools.label.Set defines hashcode(); should it be hashCode()? | CORRECTNESS | NM_LCASE_HASHCODE | 231 | High |
gov.nasa.pds.tools.label.Set.toString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 171 | Medium |
gov.nasa.pds.tools.label.Set.toString(boolean) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 203 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.SpecialPointer.CATALOG_KEY should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 35 | Medium |
gov.nasa.pds.tools.label.SpecialPointer.DESCRIPTION_KEY should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 28 | Medium |
gov.nasa.pds.tools.label.SpecialPointer.INDEX_KEY should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 33 | Medium |
gov.nasa.pds.tools.label.SpecialPointer.STRUCTURE_KEY should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 31 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.Symbol inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 33 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.TextString inherits equals and uses Object.hashCode() | BAD_PRACTICE | HE_INHERITS_EQUALS_USE_HASHCODE | 34 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mBAD_TOKEN() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 2040 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mEOL() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 1970 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mIDENTIFIER() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 757 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mINTEGER_OR_TIME() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 1618 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLLexer.mUNITS() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 1019 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should gov.nasa.pds.tools.label.antlr.ODLLexer$DFA21 be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 2436 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should gov.nasa.pds.tools.label.antlr.ODLLexer$DFA32 be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 2761 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to c3 in gov.nasa.pds.tools.label.antlr.ODLParser.group_statement(Label) | STYLE | DLS_DEAD_LOCAL_STORE | 1227 | Medium |
Dead store to id2 in gov.nasa.pds.tools.label.antlr.ODLParser.group_statement(Label) | STYLE | DLS_DEAD_LOCAL_STORE | 1209 | Medium |
Dead store to id2 in gov.nasa.pds.tools.label.antlr.ODLParser.object_statement(Label) | STYLE | DLS_DEAD_LOCAL_STORE | 773 | Medium |
Dead store to t in gov.nasa.pds.tools.label.antlr.ODLParser.object_statement(Label) | STYLE | DLS_DEAD_LOCAL_STORE | 760 | Medium |
gov.nasa.pds.tools.label.antlr.ODLParser.getTokenNames() may expose internal representation by returning ODLParser.tokenNames | MALICIOUS_CODE | EI_EXPOSE_REP | 90 | Medium |
gov.nasa.pds.tools.label.antlr.ODLParser.tokenNames should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 39 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.assignment_statement(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 1346 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.group_statement(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 1189 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.object_statement(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 753 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.scalar_value(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 1930 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.sequence_value(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 2360 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.simple_statement(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 514 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.statement(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 409 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.symbol_value(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 2311 | Medium |
Switch statement found in gov.nasa.pds.tools.label.antlr.ODLParser.value(Label) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 1824 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to LA10_1 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3870 | Medium |
Dead store to LA10_10 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3735 | Medium |
Dead store to LA10_11 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3720 | Medium |
Dead store to LA10_4 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3786 | Medium |
Dead store to LA10_5 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3885 | Medium |
Dead store to LA10_6 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3769 | Medium |
Dead store to LA10_7 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3803 | Medium |
Dead store to LA10_8 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3820 | Medium |
Dead store to LA10_9 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA10.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 3752 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to LA16_1 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4011 | Medium |
Dead store to LA16_10 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4141 | Medium |
Dead store to LA16_11 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4156 | Medium |
Dead store to LA16_12 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4171 | Medium |
Dead store to LA16_2 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4026 | Medium |
Dead store to LA16_4 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4041 | Medium |
Dead store to LA16_5 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4058 | Medium |
Dead store to LA16_6 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4075 | Medium |
Dead store to LA16_7 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4092 | Medium |
Dead store to LA16_8 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4109 | Medium |
Dead store to LA16_9 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA16.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4126 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to LA31_41 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA31.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4945 | Medium |
Dead store to LA31_67 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA31.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 4930 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to LA39_3 in gov.nasa.pds.tools.label.antlr.ODLParser$DFA39.specialStateTransition(int, IntStream) | STYLE | DLS_DEAD_LOCAL_STORE | 5044 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in gov.nasa.pds.tools.label.parser.DefaultLabelParser.consumeNewline(InputStream): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 318 | High |
Found reliance on default encoding in gov.nasa.pds.tools.label.parser.DefaultLabelParser.parseLabel(BufferedInputStream, Label, boolean): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 174 | High |
Found reliance on default encoding in gov.nasa.pds.tools.label.parser.DefaultLabelParser.parsePartial(BufferedInputStream, Label, Label): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 424 | High |
gov.nasa.pds.tools.label.parser.DefaultLabelParser.consumeSFDUHeader(InputStream) ignores result of java.io.InputStream.read(byte[]) | BAD_PRACTICE | RR_NOT_CHECKED | 283 | Medium |
Unread field: gov.nasa.pds.tools.label.parser.DefaultLabelParser.MARK_LIMIT; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 75 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Call to gov.nasa.pds.tools.dict.DictIdentifier.equals(String) in gov.nasa.pds.tools.label.validate.CatalogNameValidator.checkPointers(Label, List) | CORRECTNESS | EC_UNRELATED_TYPES | 93 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.validate.ElementValidator.validate(AttributeStatement, Label, Dictionary) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 313 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.util.VersionInfo.<static initializer>() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 18 | Medium |