FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
364500

gov.nasa.pds.vtool.VTool

BugCategoryDetailsLinePriority
gov.nasa.pds.vtool.VTool.showProgress(URL) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR1150Medium
Null pointer dereference of in in gov.nasa.pds.vtool.VTool.setParserProps(DefaultLabelParser) on exception pathCORRECTNESSNP_ALWAYS_NULL_EXCEPTION876High
Possible null pointer dereference of in in gov.nasa.pds.vtool.VTool.printRptHeader() on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION684Medium
Possible null pointer dereference of in in gov.nasa.pds.vtool.VTool.showVersion() on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION185Medium
Unread field: gov.nasa.pds.vtool.VTool.FILE_REP; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC97Medium
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYCOPYRIGHT; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC132Medium
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYDATE; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC131Medium
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYFILE; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC128Medium
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYTOOLNAME; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC129Medium
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYVERSION; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC130Medium

gov.nasa.pds.vtool.file.FileListGenerator

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.vtool.file.FileListGenerator.getHyperLinks(URL): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING263High
Possible null pointer dereference of stream in gov.nasa.pds.vtool.file.FileListGenerator.getHyperLinks(URL) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION269Medium
Redundant nullcheck of gov.nasa.pds.vtool.file.FileListGenerator.noDirFilter, which is known to be non-null in gov.nasa.pds.vtool.file.FileListGenerator.getSubDirURLNames(URL, Set)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE325Medium
Unread field: gov.nasa.pds.vtool.file.FileListGenerator.fileExt; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC59Medium

gov.nasa.pds.vtool.flags.ToolsFlags

BugCategoryDetailsLinePriority
gov.nasa.pds.vtool.flags.ToolsFlags.CONFIG should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT27Medium
gov.nasa.pds.vtool.flags.ToolsFlags.DICT should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT28Medium
gov.nasa.pds.vtool.flags.ToolsFlags.HELP should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT29Medium
gov.nasa.pds.vtool.flags.ToolsFlags.REPORT should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT30Medium
gov.nasa.pds.vtool.flags.ToolsFlags.VERSION should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT31Medium

gov.nasa.pds.vtool.flags.VToolFlags

BugCategoryDetailsLinePriority
gov.nasa.pds.vtool.flags.VToolFlags.ALIAS should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT26Medium
gov.nasa.pds.vtool.flags.VToolFlags.FOLLOW should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT27Medium
gov.nasa.pds.vtool.flags.VToolFlags.IGNOREDIR should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT28Medium
gov.nasa.pds.vtool.flags.VToolFlags.IGNOREFILE should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT29Medium
gov.nasa.pds.vtool.flags.VToolFlags.INCLUDES should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT30Medium
gov.nasa.pds.vtool.flags.VToolFlags.LOCAL should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT31Medium
gov.nasa.pds.vtool.flags.VToolFlags.PARTIAL should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT32Medium
gov.nasa.pds.vtool.flags.VToolFlags.PROGRESS should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT33Medium
gov.nasa.pds.vtool.flags.VToolFlags.REGEXP should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT34Medium
gov.nasa.pds.vtool.flags.VToolFlags.RPTSTYLE should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT35Medium
gov.nasa.pds.vtool.flags.VToolFlags.TARGET should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT36Medium
gov.nasa.pds.vtool.flags.VToolFlags.VERBOSE should be moved out of an interface and made package protectedMALICIOUS_CODEMS_OOI_PKGPROTECT37Medium

gov.nasa.pds.vtool.logging.FullLogFormatter

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.vtool.logging.ToolsLogRecord in gov.nasa.pds.vtool.logging.FullLogFormatter.format(LogRecord)STYLEBC_UNCONFIRMED_CAST50Medium

gov.nasa.pds.vtool.logging.MinimalLogFormatter

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.vtool.logging.ToolsLogRecord in gov.nasa.pds.vtool.logging.MinimalLogFormatter.format(LogRecord)STYLEBC_UNCONFIRMED_CAST57Medium

gov.nasa.pds.vtool.logging.SummaryLogFormatter

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.vtool.logging.ToolsLogRecord in gov.nasa.pds.vtool.logging.SummaryLogFormatter.format(LogRecord)STYLEBC_UNCONFIRMED_CAST56Medium

gov.nasa.pds.vtool.logging.ToolsLogFormatter

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.vtool.logging.ToolsLogRecord in gov.nasa.pds.vtool.logging.ToolsLogFormatter.format(LogRecord)STYLEBC_UNCONFIRMED_CAST36Medium

gov.nasa.pds.vtool.options.ToolsOption

BugCategoryDetailsLinePriority
gov.nasa.pds.vtool.options.ToolsOption doesn't override org.apache.commons.cli.Option.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS595Medium
Unread field: gov.nasa.pds.vtool.options.ToolsOption.argSeparator; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC29Medium

gov.nasa.pds.vtool.report.FullReport

BugCategoryDetailsLinePriority
gov.nasa.pds.vtool.report.FullReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR88Medium

gov.nasa.pds.vtool.report.JSONReport

BugCategoryDetailsLinePriority
gov.nasa.pds.vtool.report.JSONReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR105Medium

gov.nasa.pds.vtool.report.Report

BugCategoryDetailsLinePriority
Found reliance on default encoding in new gov.nasa.pds.vtool.report.Report(): new java.io.OutputStreamWriter(OutputStream)I18NDM_DEFAULT_ENCODING68High
Found reliance on default encoding in gov.nasa.pds.vtool.report.Report.setOutput(File): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING104High
Found reliance on default encoding in gov.nasa.pds.vtool.report.Report.setOutput(OutputStream): new java.io.OutputStreamWriter(OutputStream)I18NDM_DEFAULT_ENCODING92High
gov.nasa.pds.vtool.report.Report.setOutput(File) may fail to clean up java.io.WriterEXPERIMENTALOBL_UNSATISFIED_OBLIGATION104Medium

gov.nasa.pds.vtool.report.SummaryReport$SummaryRecord

BugCategoryDetailsLinePriority
Should gov.nasa.pds.vtool.report.SummaryReport$SummaryRecord be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC49Medium

gov.nasa.pds.vtool.report.XmlReport

BugCategoryDetailsLinePriority
gov.nasa.pds.vtool.report.XmlReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR102Medium