The following document contains the results of FindBugs
FindBugs Version is 2.0.3
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.vtool.VTool.showProgress(URL) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 1150 | Medium |
Null pointer dereference of in in gov.nasa.pds.vtool.VTool.setParserProps(DefaultLabelParser) on exception path | CORRECTNESS | NP_ALWAYS_NULL_EXCEPTION | 876 | High |
Possible null pointer dereference of in in gov.nasa.pds.vtool.VTool.printRptHeader() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 684 | Medium |
Possible null pointer dereference of in in gov.nasa.pds.vtool.VTool.showVersion() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 185 | Medium |
Unread field: gov.nasa.pds.vtool.VTool.FILE_REP; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 97 | Medium |
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYCOPYRIGHT; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 132 | Medium |
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYDATE; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 131 | Medium |
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYFILE; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 128 | Medium |
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYTOOLNAME; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 129 | Medium |
Unread field: gov.nasa.pds.vtool.VTool.PROPERTYVERSION; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 130 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in gov.nasa.pds.vtool.file.FileListGenerator.getHyperLinks(URL): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 263 | High |
Possible null pointer dereference of stream in gov.nasa.pds.vtool.file.FileListGenerator.getHyperLinks(URL) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 269 | Medium |
Redundant nullcheck of gov.nasa.pds.vtool.file.FileListGenerator.noDirFilter, which is known to be non-null in gov.nasa.pds.vtool.file.FileListGenerator.getSubDirURLNames(URL, Set) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 325 | Medium |
Unread field: gov.nasa.pds.vtool.file.FileListGenerator.fileExt; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 59 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.vtool.flags.ToolsFlags.CONFIG should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 27 | Medium |
gov.nasa.pds.vtool.flags.ToolsFlags.DICT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 28 | Medium |
gov.nasa.pds.vtool.flags.ToolsFlags.HELP should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 29 | Medium |
gov.nasa.pds.vtool.flags.ToolsFlags.REPORT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 30 | Medium |
gov.nasa.pds.vtool.flags.ToolsFlags.VERSION should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 31 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.vtool.flags.VToolFlags.ALIAS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 26 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.FOLLOW should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 27 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.IGNOREDIR should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 28 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.IGNOREFILE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 29 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.INCLUDES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 30 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.LOCAL should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 31 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.PARTIAL should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 32 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.PROGRESS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 33 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.REGEXP should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 34 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.RPTSTYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 35 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.TARGET should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 36 | Medium |
gov.nasa.pds.vtool.flags.VToolFlags.VERBOSE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 37 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.vtool.logging.ToolsLogRecord in gov.nasa.pds.vtool.logging.FullLogFormatter.format(LogRecord) | STYLE | BC_UNCONFIRMED_CAST | 50 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.vtool.logging.ToolsLogRecord in gov.nasa.pds.vtool.logging.MinimalLogFormatter.format(LogRecord) | STYLE | BC_UNCONFIRMED_CAST | 57 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.vtool.logging.ToolsLogRecord in gov.nasa.pds.vtool.logging.SummaryLogFormatter.format(LogRecord) | STYLE | BC_UNCONFIRMED_CAST | 56 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.vtool.logging.ToolsLogRecord in gov.nasa.pds.vtool.logging.ToolsLogFormatter.format(LogRecord) | STYLE | BC_UNCONFIRMED_CAST | 36 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.vtool.options.ToolsOption doesn't override org.apache.commons.cli.Option.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 595 | Medium |
Unread field: gov.nasa.pds.vtool.options.ToolsOption.argSeparator; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 29 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.vtool.report.FullReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 88 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.vtool.report.JSONReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 105 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in new gov.nasa.pds.vtool.report.Report(): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 68 | High |
Found reliance on default encoding in gov.nasa.pds.vtool.report.Report.setOutput(File): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 104 | High |
Found reliance on default encoding in gov.nasa.pds.vtool.report.Report.setOutput(OutputStream): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 92 | High |
gov.nasa.pds.vtool.report.Report.setOutput(File) may fail to clean up java.io.Writer | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 104 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should gov.nasa.pds.vtool.report.SummaryReport$SummaryRecord be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 49 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.vtool.report.XmlReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 102 | Medium |