FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.0

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
6921500

gov.nasa.pds.citool.CITool

BugCategoryDetailsLinePriority
gov.nasa.pds.citool.CITool.processMain(String[]) invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT552Medium
gov.nasa.pds.citool.CITool.query(CommandLine) invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT155Medium
String is incompatible with expected argument type gov.nasa.pds.citool.target.Target in gov.nasa.pds.citool.CITool.setTargets(List)CORRECTNESSGC_UNRELATED_TYPES371High
Exception is caught when Exception is not thrown in gov.nasa.pds.citool.CITool.query(File)STYLEREC_CATCH_EXCEPTION360Medium

gov.nasa.pds.citool.CIToolComparator

BugCategoryDetailsLinePriority
Dead store to sources in gov.nasa.pds.citool.CIToolComparator.compare(Target, Target, boolean)STYLEDLS_DEAD_LOCAL_STORE53Medium
Dead store to targets in gov.nasa.pds.citool.CIToolComparator.compare(Target, Target, boolean)STYLEDLS_DEAD_LOCAL_STORE54Medium

gov.nasa.pds.citool.CIToolIngester

BugCategoryDetailsLinePriority
gov.nasa.pds.citool.CIToolIngester.convertToCatalogObject() invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT213Medium
gov.nasa.pds.citool.CIToolIngester.getFilesFromStorageService(List) invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT334Medium
gov.nasa.pds.citool.CIToolIngester.catObjs isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINALMedium
gov.nasa.pds.citool.CIToolIngester.refInfo isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINALMedium
gov.nasa.pds.citool.CIToolIngester.targetAvailable isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL77Medium
Write to static field gov.nasa.pds.citool.CIToolIngester.catObjs from instance method gov.nasa.pds.citool.CIToolIngester.ingest(Target, boolean)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD128High
Write to static field gov.nasa.pds.citool.CIToolIngester.refInfo from instance method gov.nasa.pds.citool.CIToolIngester.process()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD149High

gov.nasa.pds.citool.CIToolValidator

BugCategoryDetailsLinePriority
Possible null pointer dereference of url in gov.nasa.pds.citool.CIToolValidator.parseDictionary(List, boolean) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION108Medium

gov.nasa.pds.citool.file.FileListGenerator

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.citool.file.FileListGenerator.getHyperLinks(URL): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING259High
Possible null pointer dereference of stream in gov.nasa.pds.citool.file.FileListGenerator.getHyperLinks(URL) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION265Medium
Unread field: gov.nasa.pds.citool.file.FileListGenerator.fileExt; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC59Medium

gov.nasa.pds.citool.file.MD5Checksum

BugCategoryDetailsLinePriority
Possible null pointer dereference of input in gov.nasa.pds.citool.file.MD5Checksum.createChecksum(String) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION69Medium

gov.nasa.pds.citool.ingestor.CatalogDB

BugCategoryDetailsLinePriority
Dead store to targetUri in new gov.nasa.pds.citool.ingestor.CatalogDB(String, String, String, String, Target, IngestReport)STYLEDLS_DEAD_LOCAL_STORE86Medium
Dead store to rowCount in gov.nasa.pds.citool.ingestor.CatalogDB.ingestResDS(Map)STYLEDLS_DEAD_LOCAL_STORE4198Medium
Dead store to curatingnodeid in gov.nasa.pds.citool.ingestor.CatalogDB.ingestResInfo(Map)STYLEDLS_DEAD_LOCAL_STORE4253Medium
Dead store to rowCount in gov.nasa.pds.citool.ingestor.CatalogDB.ingestResInfo(Map)STYLEDLS_DEAD_LOCAL_STORE4298Medium
gov.nasa.pds.citool.ingestor.CatalogDB.failCount isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL50Medium
gov.nasa.pds.citool.ingestor.CatalogDB.okCount isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL49Medium
gov.nasa.pds.citool.ingestor.CatalogDB.newStdValueCount should be package protectedMALICIOUS_CODEMS_PKGPROTECT51Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestSWInfo(Map) may fail to clean up java.sql.StatementEXPERIMENTALOBL_UNSATISFIED_OBLIGATION2869Medium
gov.nasa.pds.citool.ingestor.CatalogDB.deleteRecords(String) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5586Medium
gov.nasa.pds.citool.ingestor.CatalogDB.getRowCount(String) may fail to clean up java.sql.ResultSet on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5565Medium
gov.nasa.pds.citool.ingestor.CatalogDB.getRowCount(String) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5564Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDCol(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4439Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDColD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4568Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDFormRule(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4717Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDGenClass(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4862Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjAlias(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5108Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5169Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjElm(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5330Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjHier(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5397Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjStsNote(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5459Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjects(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE5258Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDStdValD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4642Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDSysClass(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4791Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollAssocDSObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2146Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2407Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollDoc(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2487Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2330Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollUsgd(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2218Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSConf(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1305Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1222Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSHost(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1465Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1603Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSMsn(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1157Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSRefInfoObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1685Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSReleaseObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4106Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSTarg(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1390Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestHostD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE611Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestHostInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE715Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestInstD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE879Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestInstHostRefInfoObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE795Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestInstInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1000Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestInstRefInfoObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1076Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestInvNodeMedia(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2684Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestInvSpcOrdNt(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2582Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE193Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnDoc(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE531Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnHost(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE365Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE452Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnObjsmy(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE272Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestNssdcdsidObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4005Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestPersElecmail(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2074Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestPersInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1960Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestPersMailAddr(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1830Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestReferenceObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE1745Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestResDS(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4188Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestResInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4278Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestSWD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2757Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestSWPur(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE2950Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestSoftwareOnlineObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3047Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestStdValObject(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE4949Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestTargetD(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3134Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestTargetDoc(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3324Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestTargetInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3239Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolDS(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3406Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolDesc(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3486Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3600Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolOnline(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3923Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolSerInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3830Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolSerSet(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3770Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolSetInfo(Map) may fail to clean up java.sql.Statement on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE3694Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ingestSWInfo(Map) may fail to close PreparedStatementBAD_PRACTICEODR_OPEN_DATABASE_RESOURCE2869Medium
gov.nasa.pds.citool.ingestor.CatalogDB.ltrim(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION5539Medium
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDCol(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4439High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDColD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4568High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDFormRule(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4717High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDGenClass(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4862High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjAlias(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING5108High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING5169High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjElm(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING5330High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjHier(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING5397High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjStsNote(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING5459High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDObjects(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING5258High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDStdValD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4642High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDDSysClass(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4791High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollAssocDSObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2146High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2407High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollDoc(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2487High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2330High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSCollUsgd(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2218High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSConf(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1305High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1222High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSHost(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1465High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1603High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSMsn(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1157High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSRefInfoObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1685High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSReleaseObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4106High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestDSTarg(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1390High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestHostD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING611High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestHostInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING715High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestInstD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING879High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestInstHostRefInfoObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING795High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestInstInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1000High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestInstRefInfoObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1076High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestInvNodeMedia(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2684High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestInvSpcOrdNt(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2582High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING193High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnDoc(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING531High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnHost(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING365High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING452High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestMsnObjsmy(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING272High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestNewStdValues(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING5022High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestNssdcdsidObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4005High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestPersElecmail(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2074High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestPersInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1960High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestPersMailAddr(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1830High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestReferenceObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING1745High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestResDS(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4188High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestResInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4278High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestSWD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2757High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestSWInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2869High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestSWPur(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING2950High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestSoftwareOnlineObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3047High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestStdValObject(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING4949High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestTargetD(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3134High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestTargetDoc(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3324High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestTargetInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3239High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolDS(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3406High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolDesc(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3486High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3600High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolOnline(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3923High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolSerInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3830High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolSerSet(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3770High
A prepared statement is generated from a nonconstant String in gov.nasa.pds.citool.ingestor.CatalogDB.ingestVolSetInfo(Map) SECURITYSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING3694High
Unread field: gov.nasa.pds.citool.ingestor.CatalogDB.SPACES; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC57Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogDB.failCount from instance method gov.nasa.pds.citool.ingestor.CatalogDB.ingestReferenceObject(Map)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD1730Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogDB.okCount from instance method gov.nasa.pds.citool.ingestor.CatalogDB.ingestReferenceObject(Map)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD1763Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogDB.failCount from instance method gov.nasa.pds.citool.ingestor.CatalogDB.ingestSoftwareOnlineObject(Map)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD3029Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogDB.okCount from instance method gov.nasa.pds.citool.ingestor.CatalogDB.ingestSoftwareOnlineObject(Map)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD3075Medium

gov.nasa.pds.citool.ingestor.CatalogRegistryIngester

BugCategoryDetailsLinePriority
Dead store to guid in gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.publishAssociation(CatalogObject, Reference)STYLEDLS_DEAD_LOCAL_STORE1106Medium
gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.createRegistryPackage() invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT1276Medium
Comparison of String parameter using == or != in gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.getRefValues(String, String, Map, CatalogObject) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ778Medium
Comparison of String parameter using == or != in gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.getRefValues(String, String, Map, CatalogObject) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ769Medium
Comparison of String parameter using == or != in gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.getRefValues(String, String, Map, CatalogObject) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ772Medium
Comparison of String parameter using == or != in gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.getRefValues(String, String, Map, CatalogObject) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ766Medium
Comparison of String parameter using == or != in gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.getRefValues(String, String, Map, CatalogObject) BAD_PRACTICEES_COMPARING_PARAMETER_STRING_WITH_EQ775Medium
gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.fileObjCount isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL65Medium
gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.registryCount isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL67Medium
gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.registryPackageName isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINALMedium
gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.storageCount isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL66Medium
gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.failCount should be package protectedMALICIOUS_CODEMS_PKGPROTECT68Medium
Exception is caught when Exception is not thrown in gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.ingestHKExtrinsicObject(CatalogObject)STYLEREC_CATCH_EXCEPTION492Medium
Self assignment of field CatalogRegistryIngester.product in gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.ingestExtrinsicObject(CatalogObject)CORRECTNESSSA_FIELD_SELF_ASSIGNMENT385High
Write to static field gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.registryPackageName from instance method gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.createRegistryPackage()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD1253High
Write to static field gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.fileObjCount from instance method gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.ingest(CatalogObject)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD189Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.registryCount from instance method gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.ingest(CatalogObject)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD179Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.failCount from instance method gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.ingestExtrinsicObject(CatalogObject)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD370Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.failCount from instance method gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.ingestHKExtrinsicObject(CatalogObject)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD486Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.failCount from instance method gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.publishAssociation(CatalogObject, Reference)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD1111Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.failCount from instance method gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.publishAssociations(CatalogObject)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD1077Medium
Write to static field gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.failCount from instance method gov.nasa.pds.citool.ingestor.CatalogRegistryIngester.updateProduct(CatalogObject, Map)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD619Medium

gov.nasa.pds.citool.logging.CompareFormatter

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.citool.logging.ToolsLogRecord in gov.nasa.pds.citool.logging.CompareFormatter.format(LogRecord)STYLEBC_UNCONFIRMED_CAST59Medium
gov.nasa.pds.citool.logging.CompareFormatter.processRecords(ToolsLogRecord) uses the same code for two branchesSTYLEDB_DUPLICATE_BRANCHES109Medium

gov.nasa.pds.citool.logging.IngestFormatter

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.citool.logging.ToolsLogRecord in gov.nasa.pds.citool.logging.IngestFormatter.format(LogRecord)STYLEBC_UNCONFIRMED_CAST55Medium
Unread field: gov.nasa.pds.citool.logging.IngestFormatter.headerPrintedPERFORMANCEURF_UNREAD_FIELD48Medium
Unread field: gov.nasa.pds.citool.logging.IngestFormatter.recordsPERFORMANCEURF_UNREAD_FIELD46Medium

gov.nasa.pds.citool.logging.ValidateFormatter

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from java.util.logging.LogRecord to gov.nasa.pds.citool.logging.ToolsLogRecord in gov.nasa.pds.citool.logging.ValidateFormatter.format(LogRecord)STYLEBC_UNCONFIRMED_CAST68Medium

gov.nasa.pds.citool.report.CompareReport

BugCategoryDetailsLinePriority
Dead store to externalProblems in gov.nasa.pds.citool.report.CompareReport.printRecordMessages(PrintWriter, Status, URI, List)STYLEDLS_DEAD_LOCAL_STORE72High

gov.nasa.pds.citool.report.IngestReport

BugCategoryDetailsLinePriority
Dead store to totalValidated in gov.nasa.pds.citool.report.IngestReport.printFooter(PrintWriter)STYLEDLS_DEAD_LOCAL_STORE139Medium
gov.nasa.pds.citool.report.IngestReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR102Medium

gov.nasa.pds.citool.report.ReferentialIntegrityReport

BugCategoryDetailsLinePriority
gov.nasa.pds.citool.report.ReferentialIntegrityReport.printRecordMessages(PrintWriter, Status, List, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR72Medium

gov.nasa.pds.citool.report.Report

BugCategoryDetailsLinePriority
Found reliance on default encoding in new gov.nasa.pds.citool.report.Report(): new java.io.OutputStreamWriter(OutputStream)I18NDM_DEFAULT_ENCODING68High
Found reliance on default encoding in gov.nasa.pds.citool.report.Report.setOutput(File): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING104High
Found reliance on default encoding in gov.nasa.pds.citool.report.Report.setOutput(OutputStream): new java.io.OutputStreamWriter(OutputStream)I18NDM_DEFAULT_ENCODING92High
gov.nasa.pds.citool.report.Report.setOutput(File) may fail to clean up java.io.WriterEXPERIMENTALOBL_UNSATISFIED_OBLIGATION104Medium

gov.nasa.pds.citool.report.ValidateReport

BugCategoryDetailsLinePriority
gov.nasa.pds.citool.report.ValidateReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR96Medium

gov.nasa.pds.citool.ri.InstrumentHostRIChecker

BugCategoryDetailsLinePriority
Dead store to parents in gov.nasa.pds.citool.ri.InstrumentHostRIChecker.performCheck(List, List)STYLEDLS_DEAD_LOCAL_STORE37Medium

gov.nasa.pds.citool.ri.InstrumentRIChecker

BugCategoryDetailsLinePriority
Dead store to parents in gov.nasa.pds.citool.ri.InstrumentRIChecker.performCheck(List, List)STYLEDLS_DEAD_LOCAL_STORE36Medium

gov.nasa.pds.citool.ri.MissionRIChecker

BugCategoryDetailsLinePriority
Dead store to parents in gov.nasa.pds.citool.ri.MissionRIChecker.performCheck(List, List)STYLEDLS_DEAD_LOCAL_STORE36Medium

gov.nasa.pds.citool.ri.PersonnelRIChecker

BugCategoryDetailsLinePriority
Dead store to parents in gov.nasa.pds.citool.ri.PersonnelRIChecker.performCheck(List, List)STYLEDLS_DEAD_LOCAL_STORE37Medium

gov.nasa.pds.citool.ri.RIChecker

BugCategoryDetailsLinePriority
gov.nasa.pds.citool.ri.RIChecker.getUnmatchedValues(Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR51Medium

gov.nasa.pds.citool.ri.ReferenceRIChecker

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.citool.ri.ReferenceRIChecker.parse(URL): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING210High
gov.nasa.pds.citool.ri.ReferenceRIChecker.validate(URL) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR178Medium
Repeated conditional test in gov.nasa.pds.citool.ri.ReferenceRIChecker.parse(URL)CORRECTNESSRpC_REPEATED_CONDITIONAL_TEST217High
Unread field: gov.nasa.pds.citool.ri.ReferenceRIChecker.DESCRIPTION; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC52Medium
Unread field: gov.nasa.pds.citool.ri.ReferenceRIChecker.ID; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC51Medium

gov.nasa.pds.citool.ri.ReferentialIntegrityValidator

BugCategoryDetailsLinePriority
Call to String.equals(gov.nasa.pds.citool.status.Status) in gov.nasa.pds.citool.ri.ReferentialIntegrityValidator.isValid(List, URL)CORRECTNESSEC_UNRELATED_TYPES62High

gov.nasa.pds.citool.ri.TargetRIChecker

BugCategoryDetailsLinePriority
Dead store to parents in gov.nasa.pds.citool.ri.TargetRIChecker.peformCheck(List, List)STYLEDLS_DEAD_LOCAL_STORE40Medium

gov.nasa.pds.citool.ri.VolumeRIChecker

BugCategoryDetailsLinePriority
Dead store to parents in gov.nasa.pds.citool.ri.VolumeRIChecker.performCheck(List, List)STYLEDLS_DEAD_LOCAL_STORE39Medium

gov.nasa.pds.citool.util.Utility

BugCategoryDetailsLinePriority
gov.nasa.pds.citool.util.Utility.ltrim(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION126Medium
gov.nasa.pds.citool.util.Utility.printDiff(String, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION199Medium

gov.nasa.pds.citool.validate.ReferenceFinderValidator

BugCategoryDetailsLinePriority
Primitive value is boxed and then immediately unboxed in gov.nasa.pds.citool.validate.ReferenceFinderValidator.findIDs(Label, AttributeStatement, List)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED204Medium
gov.nasa.pds.citool.validate.ReferenceFinderValidator.findIDs(Label, AttributeStatement, List) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR204Medium

gov.nasa.pds.citool.validate.ReferenceValidator

BugCategoryDetailsLinePriority
Primitive value is boxed and then immediately unboxed in gov.nasa.pds.citool.validate.ReferenceValidator.validate(Label)PERFORMANCEBX_BOXING_IMMEDIATELY_UNBOXED95Medium
gov.nasa.pds.citool.validate.ReferenceValidator.validate(Label) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR95Medium
Possible null pointer dereference of id in gov.nasa.pds.citool.validate.ReferenceValidator.validate(Label)CORRECTNESSNP_NULL_ON_SOME_PATH64Medium
Unread field: gov.nasa.pds.citool.validate.ReferenceValidator.REFDESC; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC34Medium
Unread field: gov.nasa.pds.citool.validate.ReferenceValidator.REFID; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC33Medium