FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
16011700

Files

ClassBugs
gov.nasa.pds.tools.inventory.reader.InventoryTableReader1
gov.nasa.pds.tools.label.BootstrapResolver3
gov.nasa.pds.tools.label.CachedLSResourceResolver1
gov.nasa.pds.tools.label.CachedLSResourceResolver$LSInputImpl1
gov.nasa.pds.tools.label.LabelValidator8
gov.nasa.pds.tools.label.LabelValidator$DOMLocator1
gov.nasa.pds.tools.label.LocationValidator2
gov.nasa.pds.tools.label.LocationValidator$ListenerExceptionPropagator1
gov.nasa.pds.tools.label.LocationValidator$SimpleExceptionHandler1
gov.nasa.pds.tools.label.SourceLocation1
gov.nasa.pds.tools.label.validate.DefaultDocumentValidator2
gov.nasa.pds.tools.label.validate.FileReferenceValidator7
gov.nasa.pds.tools.util.MD5Checksum1
gov.nasa.pds.tools.util.Utility1
gov.nasa.pds.tools.util.VersionInfo3
gov.nasa.pds.tools.validate.Identifier2
gov.nasa.pds.tools.validate.Target5
gov.nasa.pds.tools.validate.rule.RuleContext2
gov.nasa.pds.tools.validate.rule.pds3.VolumeValidationRule2
gov.nasa.pds.tools.validate.rule.pds4.BundleReferentialIntegrityRule3
gov.nasa.pds.tools.validate.rule.pds4.CollectionReferentialIntegrityRule2
gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule5
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule14
gov.nasa.pds.tools.validate.rule.pds4.SubDirectoryRule1
gov.nasa.pds.tools.validate.rule.pds4.TableFieldDefinitionRule1
gov.nasa.pds.web.ui.constants.DataSetConstants2
gov.nasa.pds.web.ui.constants.TabularManagementConstants5
gov.nasa.pds.web.ui.containers.ColumnInfo1
gov.nasa.pds.web.ui.containers.IndexContainer3
gov.nasa.pds.web.ui.containers.LabelContainer2
gov.nasa.pds.web.ui.containers.VolumeContainer1
gov.nasa.pds.web.ui.containers.dataSet.ValidationResults2
gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$NewValue1
gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$SimpleProblem2
gov.nasa.pds.web.ui.containers.tabularData.Column1
gov.nasa.pds.web.ui.containers.tabularData.Element4
gov.nasa.pds.web.ui.managers.PropsManager1
gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils10
gov.nasa.pds.web.ui.utils.DataSetValidator2
gov.nasa.pds.web.ui.utils.DateUtils2
gov.nasa.pds.web.ui.utils.ErrorCodeMapping1
gov.nasa.pds.web.ui.utils.TabularData6

gov.nasa.pds.tools.inventory.reader.InventoryTableReader

BugCategoryDetailsLinePriority
Found reliance on default encoding in new gov.nasa.pds.tools.inventory.reader.InventoryTableReader(URL): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING108High

gov.nasa.pds.tools.label.BootstrapResolver

BugCategoryDetailsLinePriority
The class name gov.nasa.pds.tools.label.BootstrapResolver shadows the simple name of the superclass org.apache.xml.resolver.helpers.BootstrapResolverBAD_PRACTICENM_SAME_SIMPLE_NAME_AS_SUPERCLASS60High
Nullcheck of href at line 151 of value previously dereferenced in gov.nasa.pds.tools.label.BootstrapResolver.resolve(String, String)CORRECTNESSRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE145Medium
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.label.BootstrapResolver.resolveEntity(String, String)STYLEREC_CATCH_EXCEPTION132Medium

gov.nasa.pds.tools.label.CachedLSResourceResolver

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.tools.label.CachedLSResourceResolver.resolveResource(String, String, String, String, String): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING217High

gov.nasa.pds.tools.label.CachedLSResourceResolver$LSInputImpl

BugCategoryDetailsLinePriority
Should gov.nasa.pds.tools.label.CachedLSResourceResolver$LSInputImpl be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC47Medium

gov.nasa.pds.tools.label.LabelValidator

BugCategoryDetailsLinePriority
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.cachedEntityResolver; locked 75% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC807Medium
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.cachedLSResolver; locked 85% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC811Medium
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.modelVersion; locked 66% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC751Medium
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.resolver; locked 76% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC230Medium
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.useLabelSchema; locked 83% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC773Medium
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.useLabelSchematron; locked 75% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC786Medium
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.userSchematronFiles; locked 75% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC220Medium
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.userSchematronTransformers; locked 83% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC199Medium

gov.nasa.pds.tools.label.LabelValidator$DOMLocator

BugCategoryDetailsLinePriority
Unread field: gov.nasa.pds.tools.label.LabelValidator$DOMLocator.urlPERFORMANCEURF_UNREAD_FIELD841Medium

gov.nasa.pds.tools.label.LocationValidator

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.LocationValidator.setChecksumManifest(Map) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS246High
Possible null pointer dereference of uri in gov.nasa.pds.tools.label.LocationValidator.getRule(URL) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION177Medium

gov.nasa.pds.tools.label.LocationValidator$ListenerExceptionPropagator

BugCategoryDetailsLinePriority
Should gov.nasa.pds.tools.label.LocationValidator$ListenerExceptionPropagator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC274Medium

gov.nasa.pds.tools.label.LocationValidator$SimpleExceptionHandler

BugCategoryDetailsLinePriority
Should gov.nasa.pds.tools.label.LocationValidator$SimpleExceptionHandler be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC357Medium

gov.nasa.pds.tools.label.SourceLocation

BugCategoryDetailsLinePriority
Comparison of String objects using == or != in gov.nasa.pds.tools.label.SourceLocation.equals(Object) BAD_PRACTICEES_COMPARING_STRINGS_WITH_EQ75Medium

gov.nasa.pds.tools.label.validate.DefaultDocumentValidator

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.label.validate.DefaultDocumentValidator.validate(ExceptionHandler, DocumentInfo) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR65Medium
Unread field: gov.nasa.pds.tools.label.validate.DefaultDocumentValidator.XML_MODEL_XPATH; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC39Medium

gov.nasa.pds.tools.label.validate.FileReferenceValidator

BugCategoryDetailsLinePriority
Dead store to children in gov.nasa.pds.tools.label.validate.FileReferenceValidator.validate(ExceptionHandler, DocumentInfo)STYLEDLS_DEAD_LOCAL_STORE158Medium
gov.nasa.pds.tools.label.validate.FileReferenceValidator.checksumManifest is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.tools.label.validate.FileReferenceValidator.handleChecksum(String, URL, TinyNodeImpl, String) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS312High
gov.nasa.pds.tools.label.validate.FileReferenceValidator.setChecksumManifest(Map) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS387High
gov.nasa.pds.tools.label.validate.FileReferenceValidator.handleChecksum(String, URL, TinyNodeImpl, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR314Medium
gov.nasa.pds.tools.label.validate.FileReferenceValidator.validate(ExceptionHandler, DocumentInfo) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR162Medium
Unread field: gov.nasa.pds.tools.label.validate.FileReferenceValidator.FILE_OBJECTS_XPATH; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC57Medium

gov.nasa.pds.tools.util.MD5Checksum

BugCategoryDetailsLinePriority
Possible null pointer dereference of input in gov.nasa.pds.tools.util.MD5Checksum.createChecksum(URL) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION70Medium

gov.nasa.pds.tools.util.Utility

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.util.Utility.getParent(URL)STYLEREC_CATCH_EXCEPTION155Medium

gov.nasa.pds.tools.util.VersionInfo

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.util.VersionInfo.<static initializer for VersionInfo>() may fail to clean up java.io.InputStreamEXPERIMENTALOBL_UNSATISFIED_OBLIGATION70Medium
gov.nasa.pds.tools.util.VersionInfo.<static initializer for VersionInfo>() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM70Medium
gov.nasa.pds.tools.util.VersionInfo.getResourceListing(String) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM236Medium

gov.nasa.pds.tools.validate.Identifier

BugCategoryDetailsLinePriority
Equals method for gov.nasa.pds.tools.validate.Identifier assumes the argument is of type IdentifierBAD_PRACTICEBC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS73Medium
gov.nasa.pds.tools.validate.Identifier.equals(Object) does not check for null argumentBAD_PRACTICENP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT72Medium

gov.nasa.pds.tools.validate.Target

BugCategoryDetailsLinePriority
Equals method for gov.nasa.pds.tools.validate.Target assumes the argument is of type TargetBAD_PRACTICEBC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS55Medium
Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in gov.nasa.pds.tools.validate.Target.equals(Object)PERFORMANCEDMI_BLOCKING_METHODS_ON_URL56High
Invocation of java.net.URL.hashCode(), which blocks to do domain name resolution, in gov.nasa.pds.tools.validate.Target.hashCode()PERFORMANCEDMI_BLOCKING_METHODS_ON_URL66High
gov.nasa.pds.tools.validate.Target.equals(Object) does not check for null argumentBAD_PRACTICENP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT55Medium
Possible null pointer dereference of uri in gov.nasa.pds.tools.validate.Target.toString() on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION51Medium

gov.nasa.pds.tools.validate.rule.RuleContext

BugCategoryDetailsLinePriority
gov.nasa.pds.tools.validate.rule.RuleContext.getChecksumManifest() is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS269High
gov.nasa.pds.tools.validate.rule.RuleContext.setChecksumManifest(Map) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS265High

gov.nasa.pds.tools.validate.rule.pds3.VolumeValidationRule

BugCategoryDetailsLinePriority
Dead store to results in gov.nasa.pds.tools.validate.rule.pds3.VolumeValidationRule.validateVolume()STYLEDLS_DEAD_LOCAL_STORE163Medium
new gov.nasa.pds.tools.validate.rule.pds3.VolumeValidationRule() may fail to clean up java.io.InputStreamEXPERIMENTALOBL_UNSATISFIED_OBLIGATION81Medium

gov.nasa.pds.tools.validate.rule.pds4.BundleReferentialIntegrityRule

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.validate.rule.pds4.BundleReferentialIntegrityRule.bundleReferentialIntegrityRule()STYLEREC_CATCH_EXCEPTION101Medium
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.validate.rule.pds4.BundleReferentialIntegrityRule.getBundleMembers(URL)STYLEREC_CATCH_EXCEPTION195Medium
gov.nasa.pds.tools.validate.rule.pds4.BundleReferentialIntegrityRule.getBundleMembers(URL) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR156Medium

gov.nasa.pds.tools.validate.rule.pds4.CollectionReferentialIntegrityRule

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.validate.rule.pds4.CollectionReferentialIntegrityRule.collectionReferentialIntegrityRule()STYLEREC_CATCH_EXCEPTION76Medium
gov.nasa.pds.tools.validate.rule.pds4.CollectionReferentialIntegrityRule.getCollectionMembers(URL) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR127Medium

gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule

BugCategoryDetailsLinePriority
Dead store to children in gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.validate(DocumentInfo)STYLEDLS_DEAD_LOCAL_STORE196Medium
gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.checksumManifest is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.handleChecksum(ValidationTarget, URL, TinyNodeImpl, String) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS337High
Possible null pointer dereference of uri in gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.validateFileReferences() on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION98Medium
Unread field: gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.FILE_OBJECTS_XPATH; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC63Medium

gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule

BugCategoryDetailsLinePriority
Dead store to xmlModels in gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer)STYLEDLS_DEAD_LOCAL_STORE314Medium
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.labelSchemaResults is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.labelSchematronResults is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.labelSchematrons is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS268High
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS269High
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS296High
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS269High
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS372High
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS373High
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS391High
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS373High
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR347Medium
Redundant nullcheck of schemaLocations, which is known to be non-null in gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE174Medium

gov.nasa.pds.tools.validate.rule.pds4.SubDirectoryRule

BugCategoryDetailsLinePriority
Dead store to filter in gov.nasa.pds.tools.validate.rule.pds4.SubDirectoryRule.testCollectionDirectories()STYLEDLS_DEAD_LOCAL_STORE46High

gov.nasa.pds.tools.validate.rule.pds4.TableFieldDefinitionRule

BugCategoryDetailsLinePriority
Unread field: gov.nasa.pds.tools.validate.rule.pds4.TableFieldDefinitionRule.xPathFactoryPERFORMANCEURF_UNREAD_FIELD55Medium

gov.nasa.pds.web.ui.constants.DataSetConstants

BugCategoryDetailsLinePriority
gov.nasa.pds.web.ui.constants.DataSetConstants.ILLEGAL_INDEXED_FOLDERS is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY201High
gov.nasa.pds.web.ui.constants.DataSetConstants.NON_INDEXED_FOLDERS is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY197High

gov.nasa.pds.web.ui.constants.TabularManagementConstants

BugCategoryDetailsLinePriority
gov.nasa.pds.web.ui.constants.TabularManagementConstants.booleanGroup isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL146High
gov.nasa.pds.web.ui.constants.TabularManagementConstants.dateTimeGroup isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL149High
gov.nasa.pds.web.ui.constants.TabularManagementConstants.numericGroup isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL143High
gov.nasa.pds.web.ui.constants.TabularManagementConstants.orderGroup isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL152High
gov.nasa.pds.web.ui.constants.TabularManagementConstants.stringGroup isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL140High

gov.nasa.pds.web.ui.containers.ColumnInfo

BugCategoryDetailsLinePriority
Class gov.nasa.pds.web.ui.containers.ColumnInfo defines non-transient non-serializable instance field columnDefBAD_PRACTICESE_BAD_FIELDHigh

gov.nasa.pds.web.ui.containers.IndexContainer

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.web.ui.containers.IndexContainer.getLabelList(): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING122High
gov.nasa.pds.web.ui.containers.IndexContainer doesn't override LabelContainer.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS223Medium
gov.nasa.pds.web.ui.containers.IndexContainer.getLabelList() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM122Medium
gov.nasa.pds.web.ui.containers.IndexContainer.getLabelList() ignores result of java.io.BufferedReader.skip(long)BAD_PRACTICESR_NOT_CHECKED126Medium

gov.nasa.pds.web.ui.containers.LabelContainer

BugCategoryDetailsLinePriority
Call to gov.nasa.pds.tools.dict.DictIdentifier.equals(String) in gov.nasa.pds.web.ui.containers.LabelContainer.findPointer(String, List)CORRECTNESSEC_UNRELATED_TYPES180High

gov.nasa.pds.web.ui.containers.VolumeContainer

BugCategoryDetailsLinePriority
gov.nasa.pds.web.ui.containers.VolumeContainer.getLastModified() may expose internal representation by returning VolumeContainer.lastModifiedMALICIOUS_CODEEI_EXPOSE_REP93Medium

gov.nasa.pds.web.ui.containers.dataSet.ValidationResults

BugCategoryDetailsLinePriority
The field gov.nasa.pds.web.ui.containers.dataSet.ValidationResults.currentBucket is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium
The field gov.nasa.pds.web.ui.containers.dataSet.ValidationResults.problemBuckets is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$NewValue

BugCategoryDetailsLinePriority
The field gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$NewValue.fileObj is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$SimpleProblem

BugCategoryDetailsLinePriority
gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$SimpleProblem.getArguments() may expose internal representation by returning ValidationResults$SimpleProblem.argumentsMALICIOUS_CODEEI_EXPOSE_REP259Medium
The field gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$SimpleProblem.fileObj is transient but isn't set by deserializationBAD_PRACTICESE_TRANSIENT_FIELD_NOT_RESTOREDMedium

gov.nasa.pds.web.ui.containers.tabularData.Column

BugCategoryDetailsLinePriority
gov.nasa.pds.web.ui.containers.tabularData.Column defines clone() but doesn't implement CloneableBAD_PRACTICECN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE117High

gov.nasa.pds.web.ui.containers.tabularData.Element

BugCategoryDetailsLinePriority
Primitive value is unboxed and coerced for ternary operator in new gov.nasa.pds.web.ui.containers.tabularData.Element(String, Column, int)CORRECTNESSBX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR25Medium
gov.nasa.pds.web.ui.containers.tabularData.Element defines clone() but doesn't implement CloneableBAD_PRACTICECN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE66High
Integral division result cast to double or float in new gov.nasa.pds.web.ui.containers.tabularData.Element(String, Column, int)STYLEICAST_IDIV_CAST_TO_DOUBLE25Medium
Class gov.nasa.pds.web.ui.containers.tabularData.Element defines non-transient non-serializable instance field columnBAD_PRACTICESE_BAD_FIELDHigh

gov.nasa.pds.web.ui.managers.PropsManager

BugCategoryDetailsLinePriority
gov.nasa.pds.web.ui.managers.PropsManager.getApplicationProperties() may fail to clean up java.io.InputStream on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE19Medium

gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils

BugCategoryDetailsLinePriority
32 bit int shifted by 56 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertSignedLSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT35High
32 bit int shifted by 56 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertSignedMSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT112High
32 bit int shifted by 32 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedLSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT74High
32 bit int shifted by 40 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedLSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT74High
32 bit int shifted by 48 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedLSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT74High
32 bit int shifted by 56 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedLSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT74High
32 bit int shifted by 32 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedMSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT148High
32 bit int shifted by 40 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedMSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT148High
32 bit int shifted by 48 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedMSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT148High
32 bit int shifted by 56 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedMSBIntegers(byte[], int)CORRECTNESSICAST_BAD_SHIFT_AMOUNT148High

gov.nasa.pds.web.ui.utils.DataSetValidator

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.web.ui.utils.DataSetValidator.validateTabElement(String, Column, TabularData): String.getBytes()I18NDM_DEFAULT_ENCODING1133High
Incorrect lazy initialization of static field gov.nasa.pds.web.ui.utils.DataSetValidator.masterDDSerialized in gov.nasa.pds.web.ui.utils.DataSetValidator.initMasterDDSerialized()MT_CORRECTNESSLI_LAZY_INIT_STATIC1087Medium

gov.nasa.pds.web.ui.utils.DateUtils

BugCategoryDetailsLinePriority
Call to method of static java.text.DateFormat in gov.nasa.pds.web.ui.utils.DateUtils.toSQLTimeStamp(Date)MT_CORRECTNESSSTCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE52Medium
gov.nasa.pds.web.ui.utils.DateUtils.MYSQL_DATE_FORMAT is a static field of type java.text.DateFormat, which isn't thread safeMT_CORRECTNESSSTCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCEHigh

gov.nasa.pds.web.ui.utils.ErrorCodeMapping

BugCategoryDetailsLinePriority
gov.nasa.pds.web.ui.utils.ErrorCodeMapping.get(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION71Medium

gov.nasa.pds.web.ui.utils.TabularData

BugCategoryDetailsLinePriority
Found reliance on default encoding in new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING78High
Found reliance on default encoding in new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long, String, int): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING131High
new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM78Medium
new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long, String, int) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM131Medium
new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long) ignores result of java.io.BufferedReader.skip(long)BAD_PRACTICESR_NOT_CHECKED83Medium
new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long, String, int) ignores result of java.io.BufferedReader.skip(long)BAD_PRACTICESR_NOT_CHECKED135Medium