The following document contains the results of FindBugs
FindBugs Version is 2.0.3
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in new gov.nasa.pds.tools.inventory.reader.InventoryTableReader(URL): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 108 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name gov.nasa.pds.tools.label.BootstrapResolver shadows the simple name of the superclass org.apache.xml.resolver.helpers.BootstrapResolver | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 60 | High |
Nullcheck of href at line 151 of value previously dereferenced in gov.nasa.pds.tools.label.BootstrapResolver.resolve(String, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 145 | Medium |
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.label.BootstrapResolver.resolveEntity(String, String) | STYLE | REC_CATCH_EXCEPTION | 132 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in gov.nasa.pds.tools.label.CachedLSResourceResolver.resolveResource(String, String, String, String, String): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 217 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should gov.nasa.pds.tools.label.CachedLSResourceResolver$LSInputImpl be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 47 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.cachedEntityResolver; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 807 | Medium |
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.cachedLSResolver; locked 85% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 811 | Medium |
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.modelVersion; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 751 | Medium |
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.resolver; locked 76% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 230 | Medium |
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.useLabelSchema; locked 83% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 773 | Medium |
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.useLabelSchematron; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 786 | Medium |
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.userSchematronFiles; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 220 | Medium |
Inconsistent synchronization of gov.nasa.pds.tools.label.LabelValidator.userSchematronTransformers; locked 83% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 199 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: gov.nasa.pds.tools.label.LabelValidator$DOMLocator.url | PERFORMANCE | URF_UNREAD_FIELD | 841 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.LocationValidator.setChecksumManifest(Map) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 246 | High |
Possible null pointer dereference of uri in gov.nasa.pds.tools.label.LocationValidator.getRule(URL) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 177 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should gov.nasa.pds.tools.label.LocationValidator$ListenerExceptionPropagator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 274 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should gov.nasa.pds.tools.label.LocationValidator$SimpleExceptionHandler be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 357 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Comparison of String objects using == or != in gov.nasa.pds.tools.label.SourceLocation.equals(Object) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 75 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.label.validate.DefaultDocumentValidator.validate(ExceptionHandler, DocumentInfo) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 65 | Medium |
Unread field: gov.nasa.pds.tools.label.validate.DefaultDocumentValidator.XML_MODEL_XPATH; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 39 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to children in gov.nasa.pds.tools.label.validate.FileReferenceValidator.validate(ExceptionHandler, DocumentInfo) | STYLE | DLS_DEAD_LOCAL_STORE | 158 | Medium |
gov.nasa.pds.tools.label.validate.FileReferenceValidator.checksumManifest is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.tools.label.validate.FileReferenceValidator.handleChecksum(String, URL, TinyNodeImpl, String) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 312 | High |
gov.nasa.pds.tools.label.validate.FileReferenceValidator.setChecksumManifest(Map) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 387 | High |
gov.nasa.pds.tools.label.validate.FileReferenceValidator.handleChecksum(String, URL, TinyNodeImpl, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 314 | Medium |
gov.nasa.pds.tools.label.validate.FileReferenceValidator.validate(ExceptionHandler, DocumentInfo) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 162 | Medium |
Unread field: gov.nasa.pds.tools.label.validate.FileReferenceValidator.FILE_OBJECTS_XPATH; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 57 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of input in gov.nasa.pds.tools.util.MD5Checksum.createChecksum(URL) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 70 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.util.Utility.getParent(URL) | STYLE | REC_CATCH_EXCEPTION | 155 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.util.VersionInfo.<static initializer for VersionInfo>() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 70 | Medium |
gov.nasa.pds.tools.util.VersionInfo.<static initializer for VersionInfo>() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 70 | Medium |
gov.nasa.pds.tools.util.VersionInfo.getResourceListing(String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 236 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Equals method for gov.nasa.pds.tools.validate.Identifier assumes the argument is of type Identifier | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | 73 | Medium |
gov.nasa.pds.tools.validate.Identifier.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 72 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Equals method for gov.nasa.pds.tools.validate.Target assumes the argument is of type Target | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | 55 | Medium |
Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in gov.nasa.pds.tools.validate.Target.equals(Object) | PERFORMANCE | DMI_BLOCKING_METHODS_ON_URL | 56 | High |
Invocation of java.net.URL.hashCode(), which blocks to do domain name resolution, in gov.nasa.pds.tools.validate.Target.hashCode() | PERFORMANCE | DMI_BLOCKING_METHODS_ON_URL | 66 | High |
gov.nasa.pds.tools.validate.Target.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 55 | Medium |
Possible null pointer dereference of uri in gov.nasa.pds.tools.validate.Target.toString() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 51 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.tools.validate.rule.RuleContext.getChecksumManifest() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 269 | High |
gov.nasa.pds.tools.validate.rule.RuleContext.setChecksumManifest(Map) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 265 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to results in gov.nasa.pds.tools.validate.rule.pds3.VolumeValidationRule.validateVolume() | STYLE | DLS_DEAD_LOCAL_STORE | 163 | Medium |
new gov.nasa.pds.tools.validate.rule.pds3.VolumeValidationRule() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.validate.rule.pds4.BundleReferentialIntegrityRule.bundleReferentialIntegrityRule() | STYLE | REC_CATCH_EXCEPTION | 101 | Medium |
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.validate.rule.pds4.BundleReferentialIntegrityRule.getBundleMembers(URL) | STYLE | REC_CATCH_EXCEPTION | 195 | Medium |
gov.nasa.pds.tools.validate.rule.pds4.BundleReferentialIntegrityRule.getBundleMembers(URL) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 156 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in gov.nasa.pds.tools.validate.rule.pds4.CollectionReferentialIntegrityRule.collectionReferentialIntegrityRule() | STYLE | REC_CATCH_EXCEPTION | 76 | Medium |
gov.nasa.pds.tools.validate.rule.pds4.CollectionReferentialIntegrityRule.getCollectionMembers(URL) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 127 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to children in gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.validate(DocumentInfo) | STYLE | DLS_DEAD_LOCAL_STORE | 196 | Medium |
gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.checksumManifest is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.handleChecksum(ValidationTarget, URL, TinyNodeImpl, String) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 337 | High |
Possible null pointer dereference of uri in gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.validateFileReferences() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 98 | Medium |
Unread field: gov.nasa.pds.tools.validate.rule.pds4.FileReferenceValidationRule.FILE_OBJECTS_XPATH; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 63 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to xmlModels in gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) | STYLE | DLS_DEAD_LOCAL_STORE | 314 | Medium |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.labelSchemaResults is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.labelSchematronResults is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.labelSchematrons is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 268 | High |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 269 | High |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 296 | High |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 269 | High |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 372 | High |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 373 | High |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 391 | High |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 373 | High |
gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchematrons(URL, ExceptionContainer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 347 | Medium |
Redundant nullcheck of schemaLocations, which is known to be non-null in gov.nasa.pds.tools.validate.rule.pds4.LabelValidationRule.validateLabelSchemas(URL, ExceptionContainer) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 174 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to filter in gov.nasa.pds.tools.validate.rule.pds4.SubDirectoryRule.testCollectionDirectories() | STYLE | DLS_DEAD_LOCAL_STORE | 46 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: gov.nasa.pds.tools.validate.rule.pds4.TableFieldDefinitionRule.xPathFactory | PERFORMANCE | URF_UNREAD_FIELD | 55 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.web.ui.constants.DataSetConstants.ILLEGAL_INDEXED_FOLDERS is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 201 | High |
gov.nasa.pds.web.ui.constants.DataSetConstants.NON_INDEXED_FOLDERS is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 197 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.web.ui.constants.TabularManagementConstants.booleanGroup isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 146 | High |
gov.nasa.pds.web.ui.constants.TabularManagementConstants.dateTimeGroup isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 149 | High |
gov.nasa.pds.web.ui.constants.TabularManagementConstants.numericGroup isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 143 | High |
gov.nasa.pds.web.ui.constants.TabularManagementConstants.orderGroup isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 152 | High |
gov.nasa.pds.web.ui.constants.TabularManagementConstants.stringGroup isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 140 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class gov.nasa.pds.web.ui.containers.ColumnInfo defines non-transient non-serializable instance field columnDef | BAD_PRACTICE | SE_BAD_FIELD | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in gov.nasa.pds.web.ui.containers.IndexContainer.getLabelList(): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 122 | High |
gov.nasa.pds.web.ui.containers.IndexContainer doesn't override LabelContainer.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 223 | Medium |
gov.nasa.pds.web.ui.containers.IndexContainer.getLabelList() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 122 | Medium |
gov.nasa.pds.web.ui.containers.IndexContainer.getLabelList() ignores result of java.io.BufferedReader.skip(long) | BAD_PRACTICE | SR_NOT_CHECKED | 126 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Call to gov.nasa.pds.tools.dict.DictIdentifier.equals(String) in gov.nasa.pds.web.ui.containers.LabelContainer.findPointer(String, List) | CORRECTNESS | EC_UNRELATED_TYPES | 180 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.web.ui.containers.VolumeContainer.getLastModified() may expose internal representation by returning VolumeContainer.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 93 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field gov.nasa.pds.web.ui.containers.dataSet.ValidationResults.currentBucket is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium | |
The field gov.nasa.pds.web.ui.containers.dataSet.ValidationResults.problemBuckets is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$NewValue.fileObj is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$SimpleProblem.getArguments() may expose internal representation by returning ValidationResults$SimpleProblem.arguments | MALICIOUS_CODE | EI_EXPOSE_REP | 259 | Medium |
The field gov.nasa.pds.web.ui.containers.dataSet.ValidationResults$SimpleProblem.fileObj is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.web.ui.containers.tabularData.Column defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 117 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Primitive value is unboxed and coerced for ternary operator in new gov.nasa.pds.web.ui.containers.tabularData.Element(String, Column, int) | CORRECTNESS | BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR | 25 | Medium |
gov.nasa.pds.web.ui.containers.tabularData.Element defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 66 | High |
Integral division result cast to double or float in new gov.nasa.pds.web.ui.containers.tabularData.Element(String, Column, int) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 25 | Medium |
Class gov.nasa.pds.web.ui.containers.tabularData.Element defines non-transient non-serializable instance field column | BAD_PRACTICE | SE_BAD_FIELD | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.web.ui.managers.PropsManager.getApplicationProperties() may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 19 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
32 bit int shifted by 56 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertSignedLSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 35 | High |
32 bit int shifted by 56 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertSignedMSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 112 | High |
32 bit int shifted by 32 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedLSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 74 | High |
32 bit int shifted by 40 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedLSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 74 | High |
32 bit int shifted by 48 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedLSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 74 | High |
32 bit int shifted by 56 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedLSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 74 | High |
32 bit int shifted by 32 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedMSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 148 | High |
32 bit int shifted by 40 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedMSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 148 | High |
32 bit int shifted by 48 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedMSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 148 | High |
32 bit int shifted by 56 bits in gov.nasa.pds.web.ui.utils.BinaryPDS4ConversionUtils.convertUnsignedMSBIntegers(byte[], int) | CORRECTNESS | ICAST_BAD_SHIFT_AMOUNT | 148 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in gov.nasa.pds.web.ui.utils.DataSetValidator.validateTabElement(String, Column, TabularData): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 1133 | High |
Incorrect lazy initialization of static field gov.nasa.pds.web.ui.utils.DataSetValidator.masterDDSerialized in gov.nasa.pds.web.ui.utils.DataSetValidator.initMasterDDSerialized() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 1087 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Call to method of static java.text.DateFormat in gov.nasa.pds.web.ui.utils.DateUtils.toSQLTimeStamp(Date) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 52 | Medium |
gov.nasa.pds.web.ui.utils.DateUtils.MYSQL_DATE_FORMAT is a static field of type java.text.DateFormat, which isn't thread safe | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.web.ui.utils.ErrorCodeMapping.get(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 71 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 78 | High |
Found reliance on default encoding in new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long, String, int): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 131 | High |
new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 78 | Medium |
new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long, String, int) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 131 | Medium |
new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long) ignores result of java.io.BufferedReader.skip(long) | BAD_PRACTICE | SR_NOT_CHECKED | 83 | Medium |
new gov.nasa.pds.web.ui.utils.TabularData(URL, List, long, Long, String, int) ignores result of java.io.BufferedReader.skip(long) | BAD_PRACTICE | SR_NOT_CHECKED | 135 | Medium |