The following document contains the results of FindBugs
FindBugs Version is 2.0.3
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to xmlModels in gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) | STYLE | DLS_DEAD_LOCAL_STORE | 281 | Medium |
gov.nasa.pds.validate.FileValidator.labelSchemaResults is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.validate.FileValidator.labelSchematronResults is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.validate.FileValidator.labelSchematrons is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 241 | High |
gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 242 | High |
gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 263 | High |
gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 242 | High |
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 339 | High |
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 340 | High |
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 355 | High |
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 340 | High |
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 314 | Medium |
Redundant nullcheck of schemaLocations, which is known to be non-null in gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 150 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.validate.ReferentialIntegrityValidator.bundleMembers is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.validate.ReferentialIntegrityValidator.bundleSecondaryMembers is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.validate.ReferentialIntegrityValidator.collectionMembers is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.validate.ReferentialIntegrityValidator.collectionSecondaryMembers is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.validate.ReferentialIntegrityValidator.lidVidReferences is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | High | |
gov.nasa.pds.validate.ReferentialIntegrityValidator.getReferences(URL) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 440 | High |
gov.nasa.pds.validate.ReferentialIntegrityValidator.validate(ExceptionHandler, DocumentInfo) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 89 | High |
gov.nasa.pds.validate.ReferentialIntegrityValidator.validate(ExceptionHandler, DocumentInfo) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 89 | High |
gov.nasa.pds.validate.ReferentialIntegrityValidator.validate(ExceptionHandler, DocumentInfo) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 140 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.validate.ValidateLauncher.doValidation(Map) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 692 | High |
gov.nasa.pds.validate.ValidateLauncher.query(CommandLine) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 227 | Medium |
Unread field: gov.nasa.pds.validate.ValidateLauncher.settings | PERFORMANCE | URF_UNREAD_FIELD | 98 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread public/protected field: gov.nasa.pds.validate.Validator.catalogs | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 93 | Medium |
Unread public/protected field: gov.nasa.pds.validate.Validator.schemaValidator | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 97 | Medium |
Unused public or protected field: gov.nasa.pds.validate.Validator.schemas | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.validate.checksum.ChecksumManifest.read(URL) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 56 | High |
gov.nasa.pds.validate.checksum.ChecksumManifest.read(URL) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 68 | High |
Found reliance on default encoding in gov.nasa.pds.validate.checksum.ChecksumManifest.read(URL): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 57 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in new gov.nasa.pds.validate.inventory.reader.InventoryTableReader(URL): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 87 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.validate.report.FullReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 72 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.validate.report.JSONReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 99 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in new gov.nasa.pds.validate.report.Report(): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 66 | High |
Found reliance on default encoding in gov.nasa.pds.validate.report.Report.setOutput(File): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 102 | High |
Found reliance on default encoding in gov.nasa.pds.validate.report.Report.setOutput(OutputStream): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 90 | High |
gov.nasa.pds.validate.report.Report.setOutput(File) may fail to clean up java.io.Writer | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 102 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.validate.report.XmlReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Equals method for gov.nasa.pds.validate.target.Target assumes the argument is of type Target | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | 46 | Medium |
Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in gov.nasa.pds.validate.target.Target.equals(Object) | PERFORMANCE | DMI_BLOCKING_METHODS_ON_URL | 47 | High |
Invocation of java.net.URL.hashCode(), which blocks to do domain name resolution, in gov.nasa.pds.validate.target.Target.hashCode() | PERFORMANCE | DMI_BLOCKING_METHODS_ON_URL | 57 | High |
gov.nasa.pds.validate.target.Target.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 46 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Equals method for gov.nasa.pds.validate.util.LidVid assumes the argument is of type LidVid | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | 73 | Medium |
gov.nasa.pds.validate.util.LidVid defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 72 | High |
gov.nasa.pds.validate.util.LidVid.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 72 | Medium |