FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
384700

gov.nasa.pds.validate.FileValidator

BugCategoryDetailsLinePriority
Dead store to xmlModels in gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer)STYLEDLS_DEAD_LOCAL_STORE281Medium
gov.nasa.pds.validate.FileValidator.labelSchemaResults is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.validate.FileValidator.labelSchematronResults is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.validate.FileValidator.labelSchematrons is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS241High
gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS242High
gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS263High
gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS242High
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS339High
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS340High
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS355High
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS340High
gov.nasa.pds.validate.FileValidator.validateLabelSchematrons(URL, ExceptionContainer) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR314Medium
Redundant nullcheck of schemaLocations, which is known to be non-null in gov.nasa.pds.validate.FileValidator.validateLabelSchemas(URL, ExceptionContainer)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE150Medium

gov.nasa.pds.validate.ReferentialIntegrityValidator

BugCategoryDetailsLinePriority
gov.nasa.pds.validate.ReferentialIntegrityValidator.bundleMembers is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.validate.ReferentialIntegrityValidator.bundleSecondaryMembers is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.validate.ReferentialIntegrityValidator.collectionMembers is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.validate.ReferentialIntegrityValidator.collectionSecondaryMembers is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.validate.ReferentialIntegrityValidator.lidVidReferences is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLSHigh
gov.nasa.pds.validate.ReferentialIntegrityValidator.getReferences(URL) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS440High
gov.nasa.pds.validate.ReferentialIntegrityValidator.validate(ExceptionHandler, DocumentInfo) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS89High
gov.nasa.pds.validate.ReferentialIntegrityValidator.validate(ExceptionHandler, DocumentInfo) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS89High
gov.nasa.pds.validate.ReferentialIntegrityValidator.validate(ExceptionHandler, DocumentInfo) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR140Medium

gov.nasa.pds.validate.ValidateLauncher

BugCategoryDetailsLinePriority
gov.nasa.pds.validate.ValidateLauncher.doValidation(Map) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS692High
gov.nasa.pds.validate.ValidateLauncher.query(CommandLine) invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT227Medium
Unread field: gov.nasa.pds.validate.ValidateLauncher.settingsPERFORMANCEURF_UNREAD_FIELD98Medium

gov.nasa.pds.validate.Validator

BugCategoryDetailsLinePriority
Unread public/protected field: gov.nasa.pds.validate.Validator.catalogsSTYLEURF_UNREAD_PUBLIC_OR_PROTECTED_FIELD93Medium
Unread public/protected field: gov.nasa.pds.validate.Validator.schemaValidatorSTYLEURF_UNREAD_PUBLIC_OR_PROTECTED_FIELD97Medium
Unused public or protected field: gov.nasa.pds.validate.Validator.schemasSTYLEUUF_UNUSED_PUBLIC_OR_PROTECTED_FIELDMedium

gov.nasa.pds.validate.checksum.ChecksumManifest

BugCategoryDetailsLinePriority
gov.nasa.pds.validate.checksum.ChecksumManifest.read(URL) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS56High
gov.nasa.pds.validate.checksum.ChecksumManifest.read(URL) is or uses a map or set of URLs, which can be a performance hogPERFORMANCEDMI_COLLECTION_OF_URLS68High
Found reliance on default encoding in gov.nasa.pds.validate.checksum.ChecksumManifest.read(URL): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING57High

gov.nasa.pds.validate.inventory.reader.InventoryTableReader

BugCategoryDetailsLinePriority
Found reliance on default encoding in new gov.nasa.pds.validate.inventory.reader.InventoryTableReader(URL): new java.io.InputStreamReader(InputStream)I18NDM_DEFAULT_ENCODING87High

gov.nasa.pds.validate.report.FullReport

BugCategoryDetailsLinePriority
gov.nasa.pds.validate.report.FullReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR72Medium

gov.nasa.pds.validate.report.JSONReport

BugCategoryDetailsLinePriority
gov.nasa.pds.validate.report.JSONReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR99Medium

gov.nasa.pds.validate.report.Report

BugCategoryDetailsLinePriority
Found reliance on default encoding in new gov.nasa.pds.validate.report.Report(): new java.io.OutputStreamWriter(OutputStream)I18NDM_DEFAULT_ENCODING66High
Found reliance on default encoding in gov.nasa.pds.validate.report.Report.setOutput(File): new java.io.FileWriter(File)I18NDM_DEFAULT_ENCODING102High
Found reliance on default encoding in gov.nasa.pds.validate.report.Report.setOutput(OutputStream): new java.io.OutputStreamWriter(OutputStream)I18NDM_DEFAULT_ENCODING90High
gov.nasa.pds.validate.report.Report.setOutput(File) may fail to clean up java.io.WriterEXPERIMENTALOBL_UNSATISFIED_OBLIGATION102Medium

gov.nasa.pds.validate.report.XmlReport

BugCategoryDetailsLinePriority
gov.nasa.pds.validate.report.XmlReport.printRecordMessages(PrintWriter, Status, URI, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR81Medium

gov.nasa.pds.validate.target.Target

BugCategoryDetailsLinePriority
Equals method for gov.nasa.pds.validate.target.Target assumes the argument is of type TargetBAD_PRACTICEBC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS46Medium
Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in gov.nasa.pds.validate.target.Target.equals(Object)PERFORMANCEDMI_BLOCKING_METHODS_ON_URL47High
Invocation of java.net.URL.hashCode(), which blocks to do domain name resolution, in gov.nasa.pds.validate.target.Target.hashCode()PERFORMANCEDMI_BLOCKING_METHODS_ON_URL57High
gov.nasa.pds.validate.target.Target.equals(Object) does not check for null argumentBAD_PRACTICENP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT46Medium

gov.nasa.pds.validate.util.LidVid

BugCategoryDetailsLinePriority
Equals method for gov.nasa.pds.validate.util.LidVid assumes the argument is of type LidVidBAD_PRACTICEBC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS73Medium
gov.nasa.pds.validate.util.LidVid defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE72High
gov.nasa.pds.validate.util.LidVid.equals(Object) does not check for null argumentBAD_PRACTICENP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT72Medium