FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.0

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
1964101

gov.nasa.pds.registry.server.connection.ConnectionManager

BugCategoryDetailsLinePriority
Call to gov.nasa.pds.registry.model.ObjectStatus.equals(String) in gov.nasa.pds.registry.server.connection.ConnectionManager.updatePackage(ViewRegistryPackage)CORRECTNESSEC_UNRELATED_TYPES323High
Incorrect lazy initialization and update of static field gov.nasa.pds.registry.server.connection.ConnectionManager.props in gov.nasa.pds.registry.server.connection.ConnectionManager.getProperties()MT_CORRECTNESSLI_LAZY_INIT_UPDATE_STATIC622High
gov.nasa.pds.registry.server.connection.ConnectionManager.props should be package protectedMALICIOUS_CODEMS_PKGPROTECTMedium
Null passed for nonnull parameter of respToViewAssociation(PagedResponse) in gov.nasa.pds.registry.server.connection.ConnectionManager.getAssociations(RegistryQuery, Integer, Integer)CORRECTNESSNP_NULL_PARAM_DEREF542Medium
Null passed for nonnull parameter of respToViewClassificationNodes(PagedResponse) in gov.nasa.pds.registry.server.connection.ConnectionManager.getClassificationNodes(RegistryQuery, Integer, Integer)CORRECTNESSNP_NULL_PARAM_DEREF502Medium
Null passed for nonnull parameter of respToViewEvents(PagedResponse) in gov.nasa.pds.registry.server.connection.ConnectionManager.getEvents(RegistryQuery, Integer, Integer)CORRECTNESSNP_NULL_PARAM_DEREF448Medium
Null passed for nonnull parameter of respToViewPackage(PagedResponse) in gov.nasa.pds.registry.server.connection.ConnectionManager.getPackages(RegistryQuery, Integer, Integer)CORRECTNESSNP_NULL_PARAM_DEREF299Medium
Null passed for nonnull parameter of respToViewProducts(PagedResponse) in gov.nasa.pds.registry.server.connection.ConnectionManager.getProducts(RegistryQuery, Integer, Integer)CORRECTNESSNP_NULL_PARAM_DEREF203Medium
Null passed for nonnull parameter of respToViewSchemes(PagedResponse) in gov.nasa.pds.registry.server.connection.ConnectionManager.getSchemes(Integer, Integer)CORRECTNESSNP_NULL_PARAM_DEREF263Medium
Null passed for nonnull parameter of respToViewService(PagedResponse) in gov.nasa.pds.registry.server.connection.ConnectionManager.getServices(Integer, Integer)CORRECTNESSNP_NULL_PARAM_DEREF232Medium
gov.nasa.pds.registry.server.connection.ConnectionManager.getProperties() may fail to clean up java.io.InputStream on checked exceptionEXPERIMENTALOBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE623Medium

gov.nasa.pds.registry.ui.client.AssociationTableModel$1

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewAssociation> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.AssociationTableModel$1.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST111Medium

gov.nasa.pds.registry.ui.client.Associations

BugCategoryDetailsLinePriority
Unread field: gov.nasa.pds.registry.ui.client.Associations.debugMsgPERFORMANCEURF_UNREAD_FIELD123Medium

gov.nasa.pds.registry.ui.client.Associations$21

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewProduct> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.Associations$21.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST1089Medium

gov.nasa.pds.registry.ui.client.ClassificationNodeTableModel$1

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewClassificationNode> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.ClassificationNodeTableModel$1.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST103Medium

gov.nasa.pds.registry.ui.client.EventTableModel$1

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewAuditableEvent> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.EventTableModel$1.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST101Medium

gov.nasa.pds.registry.ui.client.PackageTableModel$1

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewRegistryPackage> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.PackageTableModel$1.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST102Medium

gov.nasa.pds.registry.ui.client.ProductTableModel$1

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewProduct> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.ProductTableModel$1.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST109Medium

gov.nasa.pds.registry.ui.client.Products

BugCategoryDetailsLinePriority
Dead store to count in gov.nasa.pds.registry.ui.client.Products.refreshTable()STYLEDLS_DEAD_LOCAL_STORE753Medium
gov.nasa.pds.registry.ui.client.Products.toSeparatedString(List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION1321Medium
gov.nasa.pds.registry.ui.client.Products.toUpper(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION1298Medium
Write to static field gov.nasa.pds.registry.ui.client.Products.instance from instance method new gov.nasa.pds.registry.ui.client.Products()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD290Medium
Unread field: gov.nasa.pds.registry.ui.client.Products.debugMsgPERFORMANCEURF_UNREAD_FIELD160Medium
Unused public or protected field: gov.nasa.pds.registry.ui.client.Products.associationClickHanderSTYLEUUF_UNUSED_PUBLIC_OR_PROTECTED_FIELDMedium

gov.nasa.pds.registry.ui.client.Products$15

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewAssociation> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.Products$15.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST1066Medium

gov.nasa.pds.registry.ui.client.RegistryUI

BugCategoryDetailsLinePriority
gov.nasa.pds.registry.ui.client.RegistryUI.logger isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL82High
gov.nasa.pds.registry.ui.client.RegistryUI.statusInfo isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL99High
Write to static field gov.nasa.pds.registry.ui.client.RegistryUI.servers from instance method gov.nasa.pds.registry.ui.client.RegistryUI.setServers(List)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD96High

gov.nasa.pds.registry.ui.client.SchemeTableModel$1

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewScheme> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.SchemeTableModel$1.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST110Medium

gov.nasa.pds.registry.ui.client.Schemes

BugCategoryDetailsLinePriority
Unread public/protected field: gov.nasa.pds.registry.ui.client.Schemes.tempNodesSTYLEURF_UNREAD_PUBLIC_OR_PROTECTED_FIELD177Medium

gov.nasa.pds.registry.ui.client.ServiceTableModel$1

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<gov.nasa.pds.registry.ui.shared.ViewService> to gov.nasa.pds.registry.ui.client.SerializableProductResponse in gov.nasa.pds.registry.ui.client.ServiceTableModel$1.onSuccess(TableModelHelper$SerializableResponse)STYLEBC_UNCONFIRMED_CAST102Medium

gov.nasa.pds.registry.ui.client.Tab

BugCategoryDetailsLinePriority
Unused field: gov.nasa.pds.registry.ui.client.Tab.descriptionPERFORMANCEUUF_UNUSED_FIELDMedium
Unused field: gov.nasa.pds.registry.ui.client.Tab.instancePERFORMANCEUUF_UNUSED_FIELDMedium
Unused field: gov.nasa.pds.registry.ui.client.Tab.namePERFORMANCEUUF_UNUSED_FIELDMedium

gov.nasa.pds.registry.ui.client.TabList$MouseLink

BugCategoryDetailsLinePriority
Switch statement found in gov.nasa.pds.registry.ui.client.TabList$MouseLink.onBrowserEvent(Event) where default case is missingSTYLESF_SWITCH_NO_DEFAULT45Medium

gov.nasa.pds.registry.ui.shared.Constants

BugCategoryDetailsLinePriority
gov.nasa.pds.registry.ui.shared.Constants.assocTypes is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY29High
gov.nasa.pds.registry.ui.shared.Constants.eventTypes is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY24High
gov.nasa.pds.registry.ui.shared.Constants.objectTypes is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY35High
gov.nasa.pds.registry.ui.shared.Constants.status is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY20High

gov.nasa.pds.registry.ui.shared.ViewAuditableEvent

BugCategoryDetailsLinePriority
gov.nasa.pds.registry.ui.shared.ViewAuditableEvent.getTimestamp() may expose internal representation by returning ViewAuditableEvent.timestampMALICIOUS_CODEEI_EXPOSE_REP70Medium
gov.nasa.pds.registry.ui.shared.ViewAuditableEvent.setTimestamp(Date) may expose internal representation by storing an externally mutable object into ViewAuditableEvent.timestampMALICIOUS_CODEEI_EXPOSE_REP274Medium