The following document contains the results of FindBugs Report
FindBugs Version is 2.0.0
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
exceptional return value of java.io.File.mkdir() ignored in gov.nasa.pds.search.core.SearchCore.runSolrIndexer() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 103 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to mappings in gov.nasa.pds.search.core.SearchCoreLauncher.setProperties(File) | STYLE | DLS_DEAD_LOCAL_STORE | 380 | Medium |
gov.nasa.pds.search.core.SearchCoreLauncher.query(CommandLine) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 305 | Medium |
Write to static field gov.nasa.pds.search.core.util.Debugger.debugFlag from instance method new gov.nasa.pds.search.core.SearchCoreLauncher() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 148 | Medium |
Write to static field gov.nasa.pds.search.core.util.Debugger.debugFlag from instance method gov.nasa.pds.search.core.SearchCoreLauncher.query(CommandLine) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 296 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.search.core.constants.Constants.VALID_UNK_VALUES is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 14 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.search.core.extractor.RegistryExtractor.run() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 137 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to resClass in gov.nasa.pds.search.core.indexer.pds.Indexer.indexDocs(IndexWriter, File, Properties) | STYLE | DLS_DEAD_LOCAL_STORE | 103 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Write to static field gov.nasa.pds.search.core.stats.SearchCoreStats.numErrors from instance method gov.nasa.pds.search.core.logging.formatter.SearchCoreFormatter.format(LogRecord) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 65 | Medium |
Write to static field gov.nasa.pds.search.core.stats.SearchCoreStats.numWarnings from instance method gov.nasa.pds.search.core.logging.formatter.SearchCoreFormatter.format(LogRecord) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 61 | Medium |
Unread field: gov.nasa.pds.search.core.logging.formatter.SearchCoreFormatter.config | PERFORMANCE | URF_UNREAD_FIELD | 45 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in gov.nasa.pds.search.core.post.SolrPost.clean(): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 117 | High |
Possible null pointer dereference of responseStream in gov.nasa.pds.search.core.post.SolrPost.httpGet(String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 204 | Medium |
Exception is caught when Exception is not thrown in gov.nasa.pds.search.core.post.SolrPost.verifyStatus(InputStream) | STYLE | REC_CATCH_EXCEPTION | 274 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to queryMap in gov.nasa.pds.search.core.registry.ProductClass.createResultsFilters(List) | STYLE | DLS_DEAD_LOCAL_STORE | 178 | High |
Dead store to valueList in gov.nasa.pds.search.core.registry.ProductClass.checkForSubstring(OutputString, ExtendedExtrinsicObject) | STYLE | DLS_DEAD_LOCAL_STORE | 298 | Medium |
Write to static field gov.nasa.pds.search.core.stats.SearchCoreStats.numProducts from instance method gov.nasa.pds.search.core.registry.ProductClass.query(File) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 163 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.search.core.stats.SearchCoreStats.numErrors isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | 15 | Medium |
gov.nasa.pds.search.core.stats.SearchCoreStats.numProducts isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | 19 | Medium |
gov.nasa.pds.search.core.stats.SearchCoreStats.numWarnings isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | 17 | Medium |
gov.nasa.pds.search.core.stats.SearchCoreStats.localStart should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 23 | Medium |
gov.nasa.pds.search.core.stats.SearchCoreStats.overallTime should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 25 | Medium |
gov.nasa.pds.search.core.stats.SearchCoreStats.badRegistries isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 34 | High |
gov.nasa.pds.search.core.stats.SearchCoreStats.missingAssociationTargets isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 33 | High |
gov.nasa.pds.search.core.stats.SearchCoreStats.missingAssociations isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 32 | High |
gov.nasa.pds.search.core.stats.SearchCoreStats.missingSlots isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 31 | High |
gov.nasa.pds.search.core.stats.SearchCoreStats.runTimesMap isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 29 | High |
gov.nasa.pds.search.core.stats.SearchCoreStats.assocCacheHits isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 21 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.search.core.util.Debugger.debugFlag isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | 26 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.search.core.util.PropertiesUtil.getPropertiesMap(File, String) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 47 | Medium |
gov.nasa.pds.search.core.util.PropertiesUtil.getPropertiesMap(File, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 47 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in gov.nasa.pds.search.core.util.Utility.execHttpRequest(HttpRequestBase): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 127 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gov.nasa.pds.search.core.util.XMLWriter.getFilename(int, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 123 | Medium |
Unread field: gov.nasa.pds.search.core.util.XMLWriter.log | PERFORMANCE | URF_UNREAD_FIELD | 51 | Medium |