FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.0

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
503400

gov.nasa.pds.search.core.SearchCore

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.mkdir() ignored in gov.nasa.pds.search.core.SearchCore.runSolrIndexer()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE103Medium

gov.nasa.pds.search.core.SearchCoreLauncher

BugCategoryDetailsLinePriority
Dead store to mappings in gov.nasa.pds.search.core.SearchCoreLauncher.setProperties(File)STYLEDLS_DEAD_LOCAL_STORE380Medium
gov.nasa.pds.search.core.SearchCoreLauncher.query(CommandLine) invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT305Medium
Write to static field gov.nasa.pds.search.core.util.Debugger.debugFlag from instance method new gov.nasa.pds.search.core.SearchCoreLauncher()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD148Medium
Write to static field gov.nasa.pds.search.core.util.Debugger.debugFlag from instance method gov.nasa.pds.search.core.SearchCoreLauncher.query(CommandLine)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD296Medium

gov.nasa.pds.search.core.constants.Constants

BugCategoryDetailsLinePriority
gov.nasa.pds.search.core.constants.Constants.VALID_UNK_VALUES is a mutable arrayMALICIOUS_CODEMS_MUTABLE_ARRAY14High

gov.nasa.pds.search.core.extractor.RegistryExtractor

BugCategoryDetailsLinePriority
gov.nasa.pds.search.core.extractor.RegistryExtractor.run() invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT137Medium

gov.nasa.pds.search.core.indexer.pds.Indexer

BugCategoryDetailsLinePriority
Dead store to resClass in gov.nasa.pds.search.core.indexer.pds.Indexer.indexDocs(IndexWriter, File, Properties)STYLEDLS_DEAD_LOCAL_STORE103Medium

gov.nasa.pds.search.core.logging.formatter.SearchCoreFormatter

BugCategoryDetailsLinePriority
Write to static field gov.nasa.pds.search.core.stats.SearchCoreStats.numErrors from instance method gov.nasa.pds.search.core.logging.formatter.SearchCoreFormatter.format(LogRecord)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD65Medium
Write to static field gov.nasa.pds.search.core.stats.SearchCoreStats.numWarnings from instance method gov.nasa.pds.search.core.logging.formatter.SearchCoreFormatter.format(LogRecord)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD61Medium
Unread field: gov.nasa.pds.search.core.logging.formatter.SearchCoreFormatter.configPERFORMANCEURF_UNREAD_FIELD45Medium

gov.nasa.pds.search.core.post.SolrPost

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.search.core.post.SolrPost.clean(): String.getBytes()I18NDM_DEFAULT_ENCODING117High
Possible null pointer dereference of responseStream in gov.nasa.pds.search.core.post.SolrPost.httpGet(String) on exception pathCORRECTNESSNP_NULL_ON_SOME_PATH_EXCEPTION204Medium
Exception is caught when Exception is not thrown in gov.nasa.pds.search.core.post.SolrPost.verifyStatus(InputStream)STYLEREC_CATCH_EXCEPTION274Medium

gov.nasa.pds.search.core.registry.ProductClass

BugCategoryDetailsLinePriority
Dead store to queryMap in gov.nasa.pds.search.core.registry.ProductClass.createResultsFilters(List)STYLEDLS_DEAD_LOCAL_STORE178High
Dead store to valueList in gov.nasa.pds.search.core.registry.ProductClass.checkForSubstring(OutputString, ExtendedExtrinsicObject)STYLEDLS_DEAD_LOCAL_STORE298Medium
Write to static field gov.nasa.pds.search.core.stats.SearchCoreStats.numProducts from instance method gov.nasa.pds.search.core.registry.ProductClass.query(File)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD163Medium

gov.nasa.pds.search.core.stats.SearchCoreStats

BugCategoryDetailsLinePriority
gov.nasa.pds.search.core.stats.SearchCoreStats.numErrors isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL15Medium
gov.nasa.pds.search.core.stats.SearchCoreStats.numProducts isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL19Medium
gov.nasa.pds.search.core.stats.SearchCoreStats.numWarnings isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL17Medium
gov.nasa.pds.search.core.stats.SearchCoreStats.localStart should be package protectedMALICIOUS_CODEMS_PKGPROTECT23Medium
gov.nasa.pds.search.core.stats.SearchCoreStats.overallTime should be package protectedMALICIOUS_CODEMS_PKGPROTECT25Medium
gov.nasa.pds.search.core.stats.SearchCoreStats.badRegistries isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL34High
gov.nasa.pds.search.core.stats.SearchCoreStats.missingAssociationTargets isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL33High
gov.nasa.pds.search.core.stats.SearchCoreStats.missingAssociations isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL32High
gov.nasa.pds.search.core.stats.SearchCoreStats.missingSlots isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL31High
gov.nasa.pds.search.core.stats.SearchCoreStats.runTimesMap isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL29High
gov.nasa.pds.search.core.stats.SearchCoreStats.assocCacheHits isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL21Medium

gov.nasa.pds.search.core.util.Debugger

BugCategoryDetailsLinePriority
gov.nasa.pds.search.core.util.Debugger.debugFlag isn't final and can't be protected from malicious code MALICIOUS_CODEMS_CANNOT_BE_FINAL26Medium

gov.nasa.pds.search.core.util.PropertiesUtil

BugCategoryDetailsLinePriority
gov.nasa.pds.search.core.util.PropertiesUtil.getPropertiesMap(File, String) may fail to clean up java.io.InputStreamEXPERIMENTALOBL_UNSATISFIED_OBLIGATION47Medium
gov.nasa.pds.search.core.util.PropertiesUtil.getPropertiesMap(File, String) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM47Medium

gov.nasa.pds.search.core.util.Utility

BugCategoryDetailsLinePriority
Found reliance on default encoding in gov.nasa.pds.search.core.util.Utility.execHttpRequest(HttpRequestBase): String.getBytes()I18NDM_DEFAULT_ENCODING127High

gov.nasa.pds.search.core.util.XMLWriter

BugCategoryDetailsLinePriority
gov.nasa.pds.search.core.util.XMLWriter.getFilename(int, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR123Medium
Unread field: gov.nasa.pds.search.core.util.XMLWriter.logPERFORMANCEURF_UNREAD_FIELD51Medium